Skip to content

Fixed flaky p2p test#2774

Merged
pompon0 merged 2 commits intomainfrom
gprusak-flake
Jan 27, 2026
Merged

Fixed flaky p2p test#2774
pompon0 merged 2 commits intomainfrom
gprusak-flake

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Jan 27, 2026

MConnection.sendRoutine() was incorrectly returning DeadlineExceeded in case flushing timer returned at the moment the context was cancelled (context error should be returned instead).

@pompon0 pompon0 requested review from arajasek and masih and removed request for arajasek January 27, 2026 14:30
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 27, 2026, 2:32 PM

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.90%. Comparing base (e3db226) to head (d5b48b9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
+ Coverage   52.19%   56.90%   +4.71%     
==========================================
  Files        1961     2004      +43     
  Lines      156771   164645    +7874     
==========================================
+ Hits        81826    93699   +11873     
+ Misses      67297    62728    -4569     
- Partials     7648     8218     +570     
Flag Coverage Δ
sei-chain 41.73% <0.00%> (-0.01%) ⬇️
sei-cosmos 48.13% <ø> (?)
sei-db 68.72% <ø> (ø)
sei-tendermint 58.62% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/p2p/conn/connection.go 92.00% <100.00%> (ø)

... and 431 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge (squash) January 27, 2026 14:38
@pompon0 pompon0 merged commit 1112564 into main Jan 27, 2026
45 of 46 checks passed
@pompon0 pompon0 deleted the gprusak-flake branch January 27, 2026 14:53
arajasek pushed a commit that referenced this pull request Jan 27, 2026
MConnection.sendRoutine() was incorrectly returning DeadlineExceeded in
case flushing timer returned at the moment the context was cancelled
(context error should be returned instead).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants