Remove Community Tax#278
Merged
Merged
Conversation
philipsu522
reviewed
Oct 4, 2022
| if upgradeName == "1.2.3beta" { | ||
| newVM, err := app.mm.RunMigrations(ctx, app.configurator, fromVM) | ||
| if err != nil { | ||
| return newVM, err |
Contributor
There was a problem hiding this comment.
should we return nil, err here?
Contributor
Author
There was a problem hiding this comment.
Yea I wasn't sure here. I defaulted to what osmosis did which was still returning the newVM with the err: https://github.com/osmosis-labs/osmosis/blob/c960e4a6d443d8d0a434179312e86c99600faae9/app/upgrades/v7/upgrades.go#L32 . But if this is better practice can change to nil
philipsu522
approved these changes
Oct 4, 2022
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context The code incorrectly checks padding for address. 3 should be outside the int cast ## Testing performed to validate your change
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context The code incorrectly checks padding for address. 3 should be outside the int cast ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the community tax param in
distributionto 0 effectively removing the community pooldistributionmoduleCommunityTaxparam to 01.2.3betawhere we perform the upgrade / store migration for thedistributionmodule