Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
==========================================
+ Coverage 46.97% 56.64% +9.66%
==========================================
Files 1965 2031 +66
Lines 160525 165854 +5329
==========================================
+ Hits 75410 93940 +18530
+ Misses 78585 63681 -14904
- Partials 6530 8233 +1703
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
stevenlanders
approved these changes
Feb 4, 2026
pdrobnjak
approved these changes
Feb 4, 2026
arajasek
approved these changes
Feb 4, 2026
c430ba4 to
cde2212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
In giga signatures are explicitly decoded here https://github.com/sei-protocol/sei-chain/blob/main/app/app.go#L1723 so the previous decoding (that's skipped by this PR) is not necessary. For the fallback scenario, signature decoding will be handled by the ante handler's lazy decoding logic: https://github.com/sei-protocol/sei-chain/blob/main/x/evm/ante/preprocess.go#L59
Testing performed to validate your change
existing tests