Skip to content

[giga] avoid double signature decoding#2797

Merged
codchen merged 1 commit intomainfrom
tony/prevent-double-sigverify
Feb 5, 2026
Merged

[giga] avoid double signature decoding#2797
codchen merged 1 commit intomainfrom
tony/prevent-double-sigverify

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Feb 4, 2026

Describe your changes and provide context

In giga signatures are explicitly decoded here https://github.com/sei-protocol/sei-chain/blob/main/app/app.go#L1723 so the previous decoding (that's skipped by this PR) is not necessary. For the fallback scenario, signature decoding will be handled by the ante handler's lazy decoding logic: https://github.com/sei-protocol/sei-chain/blob/main/x/evm/ante/preprocess.go#L59

Testing performed to validate your change

existing tests

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 5, 2026, 3:38 AM

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.64%. Comparing base (3d6356d) to head (cde2212).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
+ Coverage   46.97%   56.64%   +9.66%     
==========================================
  Files        1965     2031      +66     
  Lines      160525   165854    +5329     
==========================================
+ Hits        75410    93940   +18530     
+ Misses      78585    63681   -14904     
- Partials     6530     8233    +1703     
Flag Coverage Δ
sei-chain 41.50% <100.00%> (-0.05%) ⬇️
sei-cosmos 48.12% <ø> (-0.01%) ⬇️
sei-db 68.72% <ø> (ø)
sei-tendermint 58.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 71.24% <100.00%> (+0.07%) ⬆️

... and 319 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/prevent-double-sigverify branch from c430ba4 to cde2212 Compare February 5, 2026 03:37
@codchen codchen merged commit ec9e52e into main Feb 5, 2026
43 checks passed
@codchen codchen deleted the tony/prevent-double-sigverify branch February 5, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants