Skip to content

Fix inconsistent config for self remediation behind interval#2883

Merged
masih merged 2 commits intomainfrom
masih/remediation-block-behind-config-missmatch
Feb 13, 2026
Merged

Fix inconsistent config for self remediation behind interval#2883
masih merged 2 commits intomainfrom
masih/remediation-block-behind-config-missmatch

Conversation

@masih
Copy link
Collaborator

@masih masih commented Feb 13, 2026

All configuration for the past 3 years have been using the wrong value for the self remediation behind interval.

Change the config mapping to use the current value to reduce breakages.

As a result of this change, configured value for self remediation behind interval is now respected, instead of always using the default 60s.

See:

All configuration for the past 3 years have been using the wrong value
for the self remediation behind interval.

Change the config mapping to use the current value to reduce breakages.

As a result of this change, configured value for self remediation behind
interval is now respected, instead of always using the default 60s.

See:
 * sei-protocol/sei-tendermint#120
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 13, 2026, 11:25 AM

@masih
Copy link
Collaborator Author

masih commented Feb 13, 2026

Based on a quick search we have never been using the right value at least in our setups.

@masih masih enabled auto-merge (squash) February 13, 2026 11:24
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.16%. Comparing base (c8aaff5) to head (eda75b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/config/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
- Coverage   57.18%   57.16%   -0.02%     
==========================================
  Files        2091     2091              
  Lines      171179   171179              
==========================================
- Hits        97890    97861      -29     
- Misses      64579    64602      +23     
- Partials     8710     8716       +6     
Flag Coverage Δ
sei-chain 52.62% <0.00%> (-0.02%) ⬇️
sei-cosmos 48.14% <ø> (ø)
sei-db 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/config/config.go 69.24% <0.00%> (ø)

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih merged commit 7fb1494 into main Feb 13, 2026
39 of 40 checks passed
@masih masih deleted the masih/remediation-block-behind-config-missmatch branch February 13, 2026 11:45
@seidroid
Copy link

seidroid bot commented Feb 13, 2026

Created backport PR for release/v6.3:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-2883-to-release/v6.3
git worktree add --checkout .worktree/backport-2883-to-release/v6.3 backport-2883-to-release/v6.3
cd .worktree/backport-2883-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x 7fb14943da686a8aab3fe0a0ba161cee2b7e541a
git push --force-with-lease

masih added a commit that referenced this pull request Feb 13, 2026
… behind interval (#2884)

Backport of #2883 to `release/v6.3`.

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants