Fix inconsistent config for self remediation behind interval#2883
Merged
Fix inconsistent config for self remediation behind interval#2883
Conversation
All configuration for the past 3 years have been using the wrong value for the self remediation behind interval. Change the config mapping to use the current value to reduce breakages. As a result of this change, configured value for self remediation behind interval is now respected, instead of always using the default 60s. See: * sei-protocol/sei-tendermint#120
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Collaborator
Author
|
Based on a quick search we have never been using the right value at least in our setups. |
pompon0
approved these changes
Feb 13, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
- Coverage 57.18% 57.16% -0.02%
==========================================
Files 2091 2091
Lines 171179 171179
==========================================
- Hits 97890 97861 -29
- Misses 64579 64602 +23
- Partials 8710 8716 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Feb 13, 2026
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-2883-to-release/v6.3
git worktree add --checkout .worktree/backport-2883-to-release/v6.3 backport-2883-to-release/v6.3
cd .worktree/backport-2883-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x 7fb14943da686a8aab3fe0a0ba161cee2b7e541a
git push --force-with-lease |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All configuration for the past 3 years have been using the wrong value for the self remediation behind interval.
Change the config mapping to use the current value to reduce breakages.
As a result of this change, configured value for self remediation behind interval is now respected, instead of always using the default 60s.
See: