Backport release/v6.3: fix(ledger): upgrade ledger-cosmos-go to v1.0.0 for Cosmos app v2.34+ compatibility#2894
Conversation
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-2891-to-release/v6.3
git worktree add --checkout .worktree/backport-2891-to-release/v6.3 backport-2891-to-release/v6.3
cd .worktree/backport-2891-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x 927626b4adf777316681b7500090e3bdc5a74ebb
git push --force-with-lease |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
… compatibility (#2891) Upgrades `ledger-cosmos-go` from v0.12.2 to v1.0.0 to fix Ledger signing with Cosmos app v2.34+. **Changes:** - Upgrade `ledger-cosmos-go` v0.12.2 → v1.0.0 - Update `SignSECP256K1` interface to include sign mode parameter (required by v1.0.0) - Fix `btcec.SignCompact` API change in `secp256k1_nocgo.go` (v2.3.5 returns 1 value) - Update DER signature parsing to use `btcec/v2/ecdsa.ParseDERSignature` **Root cause:** The old library used an outdated APDU protocol incompatible with newer Cosmos Ledger app versions, causing `APDU Error Code: 0x698a` failures. - Successfully signed and broadcast transactions using Ledger Nano S with Cosmos app v2.38.6 - Verified signature format conversion (DER → 64-byte R||S) works correctly - Tested on Sei testnet (atlantic-2) --------- Co-authored-by: Masih H. Derkani <m@derkani.org> (cherry picked from commit 927626b)
df86699 to
4a76f0e
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (39.28%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/v6.3 #2894 +/- ##
================================================
+ Coverage 42.20% 43.43% +1.23%
================================================
Files 1520 1866 +346
Lines 121013 155401 +34388
================================================
+ Hits 51073 67506 +16433
- Misses 65496 81846 +16350
- Partials 4444 6049 +1605
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #2891 to
release/v6.3.