Skip to content

Backport release/v6.3: fix(ledger): upgrade ledger-cosmos-go to v1.0.0 for Cosmos app v2.34+ compatibility#2894

Merged
philipsu522 merged 3 commits intorelease/v6.3from
backport-2891-to-release/v6.3
Feb 14, 2026
Merged

Backport release/v6.3: fix(ledger): upgrade ledger-cosmos-go to v1.0.0 for Cosmos app v2.34+ compatibility#2894
philipsu522 merged 3 commits intorelease/v6.3from
backport-2891-to-release/v6.3

Conversation

@seidroid
Copy link

@seidroid seidroid bot commented Feb 13, 2026

Backport of #2891 to release/v6.3.

@seidroid seidroid bot added the backport label Feb 13, 2026
@seidroid
Copy link
Author

seidroid bot commented Feb 13, 2026

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-2891-to-release/v6.3
git worktree add --checkout .worktree/backport-2891-to-release/v6.3 backport-2891-to-release/v6.3
cd .worktree/backport-2891-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x 927626b4adf777316681b7500090e3bdc5a74ebb
git push --force-with-lease

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 14, 2026, 12:36 AM

… compatibility (#2891)

Upgrades `ledger-cosmos-go` from v0.12.2 to v1.0.0 to fix Ledger signing
with Cosmos app v2.34+.

**Changes:**
- Upgrade `ledger-cosmos-go` v0.12.2 → v1.0.0
- Update `SignSECP256K1` interface to include sign mode parameter
(required by v1.0.0)
- Fix `btcec.SignCompact` API change in `secp256k1_nocgo.go` (v2.3.5
returns 1 value)
- Update DER signature parsing to use `btcec/v2/ecdsa.ParseDERSignature`

**Root cause:** The old library used an outdated APDU protocol
incompatible with newer Cosmos Ledger app versions, causing `APDU Error
Code: 0x698a` failures.

- Successfully signed and broadcast transactions using Ledger Nano S
with Cosmos app v2.38.6
- Verified signature format conversion (DER → 64-byte R||S) works
correctly
- Tested on Sei testnet (atlantic-2)

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>
(cherry picked from commit 927626b)
@besated besated force-pushed the backport-2891-to-release/v6.3 branch from df86699 to 4a76f0e Compare February 14, 2026 00:03
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

❌ Patch coverage is 39.28571% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.43%. Comparing base (476b88d) to head (3def0be).
⚠️ Report is 1 commits behind head on release/v6.3.

Files with missing lines Patch % Lines
sei-cosmos/crypto/ledger/ledger_secp256k1.go 30.43% 26 Missing and 6 partials ⚠️
sei-cosmos/crypto/keyring/keyring.go 66.66% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (39.28%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (38.45%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.3    #2894      +/-   ##
================================================
+ Coverage         42.20%   43.43%   +1.23%     
================================================
  Files              1520     1866     +346     
  Lines            121013   155401   +34388     
================================================
+ Hits              51073    67506   +16433     
- Misses            65496    81846   +16350     
- Partials           4444     6049    +1605     
Flag Coverage Δ
sei-chain 42.54% <ø> (+<0.01%) ⬆️
sei-cosmos 38.21% <38.18%> (+0.17%) ⬆️
sei-db 45.16% <ø> (-0.09%) ⬇️
sei-ibc-go 55.96% <ø> (ø)
sei-tendermint 47.54% <100.00%> (?)
sei-wasmd 41.54% <ø> (-0.02%) ⬇️
sei-wasmvm 39.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ei-cosmos/crypto/keys/secp256k1/secp256k1_nocgo.go 57.89% <100.00%> (+5.51%) ⬆️
sei-cosmos/crypto/ledger/ledger_mock.go 61.22% <100.00%> (+59.26%) ⬆️
sei-tendermint/crypto/secp256k1/secp256k1.go 73.17% <100.00%> (ø)
sei-cosmos/crypto/keyring/keyring.go 60.59% <66.66%> (+0.39%) ⬆️
sei-cosmos/crypto/ledger/ledger_secp256k1.go 50.37% <30.43%> (+50.37%) ⬆️

... and 353 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih marked this pull request as ready for review February 14, 2026 01:28
@philipsu522 philipsu522 merged commit cf86df0 into release/v6.3 Feb 14, 2026
61 of 67 checks passed
@philipsu522 philipsu522 deleted the backport-2891-to-release/v6.3 branch February 14, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants