Skip to content

Fix flaky TestRPC JSON-RPC test due to hardcoded port#2945

Merged
masih merged 2 commits intomainfrom
masih/fix-json-rpc-port-clash
Feb 23, 2026
Merged

Fix flaky TestRPC JSON-RPC test due to hardcoded port#2945
masih merged 2 commits intomainfrom
masih/fix-json-rpc-port-clash

Conversation

@masih
Copy link
Collaborator

@masih masih commented Feb 21, 2026

Make the port and unix socket unique per JSON-RPC test.

Flaked on main.

@github-actions
Copy link

github-actions bot commented Feb 21, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 22, 2026, 4:34 AM

Make the port and unix socket unique per JSON-RPC test.
@masih masih force-pushed the masih/fix-json-rpc-port-clash branch from 8c77a61 to 633e37c Compare February 21, 2026 10:17
@masih masih marked this pull request as ready for review February 21, 2026 10:19
@masih masih enabled auto-merge (squash) February 21, 2026 10:20
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.83%. Comparing base (f4b318c) to head (439fd70).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
+ Coverage   57.82%   57.83%   +0.01%     
==========================================
  Files        2110     2110              
  Lines      174122   174057      -65     
==========================================
- Hits       100681   100663      -18     
+ Misses      64464    64427      -37     
+ Partials     8977     8967      -10     
Flag Coverage Δ
sei-db 68.49% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih merged commit bfb3d64 into main Feb 23, 2026
38 checks passed
@masih masih deleted the masih/fix-json-rpc-port-clash branch February 23, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants