Skip to content

Fix flaky TestClientMethodCalls by using eventual time assertion#2946

Merged
masih merged 4 commits intomainfrom
masih/tm-event-test-fix
Feb 23, 2026
Merged

Fix flaky TestClientMethodCalls by using eventual time assertion#2946
masih merged 4 commits intomainfrom
masih/tm-event-test-fix

Conversation

@masih
Copy link
Collaborator

@masih masih commented Feb 21, 2026

Switch to using eventual arrival of events instead of a fixed timeout.

Also refine the coverage config to avoid miss leading patch coverage diff on small changes.

Flaked on main.

Switch to using eventual arrival of events instead of a fixed timeout.
@github-actions
Copy link

github-actions bot commented Feb 21, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 23, 2026, 9:27 AM

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.30%. Comparing base (bfb3d64) to head (4119180).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/rpc/client/helpers.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2946       +/-   ##
===========================================
+ Coverage   57.83%   69.30%   +11.47%     
===========================================
  Files        2110        6     -2104     
  Lines      174124      492   -173632     
===========================================
- Hits       100711      341   -100370     
+ Misses      64451      118    -64333     
+ Partials     8962       33     -8929     
Flag Coverage Δ
sei-chain 80.00% <50.00%> (+22.18%) ⬆️
sei-db 68.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/rpc/client/helpers.go 80.00% <50.00%> (-2.36%) ⬇️

... and 2104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih marked this pull request as ready for review February 21, 2026 10:57
@masih masih requested review from bdchatham and pompon0 February 21, 2026 10:57
@masih masih enabled auto-merge (squash) February 21, 2026 10:58
@masih masih merged commit 80b9aae into main Feb 23, 2026
38 of 39 checks passed
@masih masih deleted the masih/tm-event-test-fix branch February 23, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants