Fix flaky TestClientMethodCalls by using eventual time assertion#2946
Merged
Fix flaky TestClientMethodCalls by using eventual time assertion#2946
TestClientMethodCalls by using eventual time assertion#2946Conversation
Switch to using eventual arrival of events instead of a fixed timeout.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
===========================================
+ Coverage 57.83% 69.30% +11.47%
===========================================
Files 2110 6 -2104
Lines 174124 492 -173632
===========================================
- Hits 100711 341 -100370
+ Misses 64451 118 -64333
+ Partials 8962 33 -8929
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bdchatham
approved these changes
Feb 21, 2026
philipsu522
reviewed
Feb 23, 2026
philipsu522
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using eventual arrival of events instead of a fixed timeout.
Also refine the coverage config to avoid miss leading patch coverage diff on small changes.
Flaked on main.