Skip to content

Migrate tendermint logging to slog and remove go-kit/log dependency#2987

Merged
masih merged 17 commits intomainfrom
masih/seilog-stage-1
Mar 2, 2026
Merged

Migrate tendermint logging to slog and remove go-kit/log dependency#2987
masih merged 17 commits intomainfrom
masih/seilog-stage-1

Conversation

@masih
Copy link
Collaborator

@masih masih commented Feb 27, 2026

Remove dependency to go-kit/log and logfmt, and adapt existing logging utility libraries to use Go SDK's slog

The changes here intentionally aim to introduce as little changes as possible, and are part of the larger integration of seilog, an extended slog library into sei-chain.

Remove dependency to go-kit/log and logfmt, and adapt existing logging
utility libraries to use Go SDK's `slog`

The changes here intentionally aim to introduce as little changes as
possible, and are part of the larger integration of `seilog`, an
extended `slog` library into sei-chain.
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 2, 2026, 3:17 PM

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 84.15301% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.56%. Comparing base (94a7bad) to head (731e05d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/libs/log/tm_logger.go 87.94% 14 Missing and 3 partials ⚠️
sei-tendermint/libs/log/testing_logger.go 33.33% 2 Missing and 2 partials ⚠️
sei-tendermint/libs/log/nop.go 60.00% 2 Missing ⚠️
cmd/seid/cmd/blocktest.go 0.00% 1 Missing ⚠️
cmd/seid/cmd/ethreplay.go 0.00% 1 Missing ⚠️
cmd/seid/cmd/snapshot.go 0.00% 1 Missing ⚠️
sei-cosmos/client/pruning/main.go 0.00% 1 Missing ⚠️
sei-tendermint/libs/log/testing.go 87.50% 1 Missing ⚠️
tools/migration/sc/migrator.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2987       +/-   ##
===========================================
+ Coverage   58.22%   60.56%    +2.34%     
===========================================
  Files        2113       76     -2037     
  Lines      173639    11630   -162009     
===========================================
- Hits       101093     7044    -94049     
+ Misses      63534     3931    -59603     
+ Partials     9012      655     -8357     
Flag Coverage Δ
sei-chain-pr 60.15% <84.15%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/p2p/conn/oldmux.go 94.00% <100.00%> (+1.25%) ⬆️
sei-tendermint/libs/log/default.go 100.00% <100.00%> (+25.49%) ⬆️
sei-tendermint/node/node.go 58.13% <100.00%> (-2.07%) ⬇️
cmd/seid/cmd/blocktest.go 0.00% <0.00%> (ø)
cmd/seid/cmd/ethreplay.go 0.00% <0.00%> (ø)
cmd/seid/cmd/snapshot.go 0.00% <0.00%> (ø)
sei-cosmos/client/pruning/main.go 0.00% <0.00%> (ø)
sei-tendermint/libs/log/testing.go 61.53% <87.50%> (+11.53%) ⬆️
tools/migration/sc/migrator.go 0.00% <0.00%> (ø)
sei-tendermint/libs/log/nop.go 66.66% <60.00%> (-33.34%) ⬇️
... and 2 more

... and 2042 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih
Copy link
Collaborator Author

masih commented Feb 27, 2026

Coverage drop is miss-leading and a result of partial to full comparison. Fixed separately here: #2989

@masih masih enabled auto-merge (squash) February 27, 2026 17:57
@masih masih requested a review from bdchatham March 2, 2026 09:45
@masih
Copy link
Collaborator Author

masih commented Mar 2, 2026

Flaking test fixed here.

@masih masih merged commit b6685c1 into main Mar 2, 2026
35 checks passed
@masih masih deleted the masih/seilog-stage-1 branch March 2, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants