Extend DB benchmark to support state store (SS) backends#2995
Merged
Conversation
Add SSPebbleDB and SSComposite backend types so the existing ERC20 benchmark can drive the historical state store using the same changeset write path. Made-with: Cursor
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Add a combinedWrapper that fans out changeset writes to both a State Commit and State Store backend, mirroring production. Two new backend types: FlatKV+SSPebble and CompositeDual+SSComposite. Made-with: Cursor
Kbhat1
requested review from
cody-littley and
yzang2019
and removed request for
yzang2019
Verifies SSPebbleDB and FlatKV+SSPebble work with the existing runBenchmark harness (version tracking, changeset generation, etc). Made-with: Cursor
SSPebbleDB bypassed the SS layer (Tier 2) and hit raw PebbleDB MVCC directly - not a real production path. All SS backends now go through CompositeStateStore, matching the architecture. Extracted shared openSSComposite helper to deduplicate SS creation. Made-with: Cursor
Drop FlatKV+SSComposite since the production path is CompositeDual+SS. Fix combinedWrapper version tracking to use SS version (consistent across all SC backends). Made-with: Cursor
Kbhat1
changed the title
cody-littley
approved these changes
Mar 2, 2026
Contributor
cody-littley
left a comment
cody-littley
left a comment
There was a problem hiding this comment.
LGTM once the config file is fixed.
I like how low-touch this ended up being... I was initially concerned that this would result in a big diff inside the benchmark that would conflict with my in-flight branches. So only seeing a new wrapper is a relief. 😅
sei-db/state_db/bench/cryptosim/config/ss-composite-config.json
Outdated
Show resolved
Hide resolved
Avoids config drift when defaults change. Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
==========================================
- Coverage 58.28% 58.13% -0.15%
==========================================
Files 2108 2112 +4
Lines 173680 173467 -213
==========================================
- Hits 101223 100851 -372
- Misses 63428 63593 +165
+ Partials 9029 9023 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
yzang2019
approved these changes
Mar 2, 2026
WorkingCommitInfo().Version returns the *next* version to be committed, not the last committed version. This was missed when 37f1b8d updated memIAVLWrapper to use base.Version(), causing all Composite SC benchmarks to fail with an off-by-one version assertion. Made-with: Cursor
yzang2019
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Describe your changes and provide context - Extend cryptosim DB benchmark to support state store (SS) backends via a lightweight StateStore → DBWrapper adapter - Adds SSPebbleDB (raw MVCC) and SSComposite (full CompositeStateStore with EVM sub-DB routing) so the same ERC20 changeset workload can benchmark the historical state store - Suppports mode for SC + SS ## Testing performed to validate your change - running bench against various different configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Extend cryptosim DB benchmark to support state store (SS) backends via a lightweight StateStore → DBWrapper adapter
Adds SSPebbleDB (raw MVCC) and SSComposite (full CompositeStateStore with EVM sub-DB routing) so the same ERC20 changeset workload can benchmark the historical state store
Suppports mode for SC + SS
Testing performed to validate your change