Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
==========================================
- Coverage 58.29% 58.25% -0.04%
==========================================
Files 2108 2108
Lines 173730 173629 -101
==========================================
- Hits 101272 101155 -117
- Misses 63433 63449 +16
Partials 9025 9025
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yzang2019
approved these changes
Mar 4, 2026
Contributor
yzang2019
left a comment
yzang2019
left a comment
There was a problem hiding this comment.
Do we need to fix the dashboard after converting to otel?
Contributor
Author
When I did the conversion, I was careful that the resulting metric names matched the prior metrics names. I verified that the existing dashboard worked as expected with local testing. |
Kbhat1
approved these changes
Mar 4, 2026
yzang2019
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Describe your changes and provide context Covert cryptosim metrics to the open telemetry API in order to be uniform with the rest of the codebase. ## Testing performed to validate your change Ran benchmark locally, verified that dashboard still works. --------- Co-authored-by: Cody Littley <cody.littley@seinetwork.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Covert cryptosim metrics to the open telemetry API in order to be uniform with the rest of the codebase.
Testing performed to validate your change
Ran benchmark locally, verified that dashboard still works.