fix(flatkv): sync SNAPSHOT_BASE on WriteSnapshot to avoid unnecessary WAL catchup on restart#3011
fix(flatkv): sync SNAPSHOT_BASE on WriteSnapshot to avoid unnecessary WAL catchup on restart#3011blindchaser merged 5 commits intomainfrom
Conversation
… WAL catchup on restart
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 665854e8d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| commitStorageEntry(t, s, Address{0xF0}, Slot{0x02}, []byte{0x02}) | ||
| require.NoError(t, s.WriteSnapshot("")) | ||
|
|
||
| flatkvDir := filepath.Join(dir, "data", flatkvRootDir) |
There was a problem hiding this comment.
Use the correct FlatKV root in snapshot-base test
TestWriteSnapshotUpdatesSnapshotBase initializes the store with NewCommitStore(dir, ...), but then reads SNAPSHOT_BASE from filepath.Join(dir, "data", flatkvRootDir, ...); NewCommitStore uses the provided dbDir directly (see store.go), so this path points to the wrong location and the read will fail with ENOENT, meaning the new regression test does not validate the behavior it intends to cover.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
==========================================
- Coverage 58.39% 58.28% -0.12%
==========================================
Files 2109 2108 -1
Lines 174936 173733 -1203
==========================================
- Hits 102161 101266 -895
+ Misses 63758 63438 -320
- Partials 9017 9029 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2cf561d to
9d9029e
Compare
… WAL catchup on restart (#3011) ## Describe your changes and provide context ## Testing performed to validate your change
Describe your changes and provide context
Testing performed to validate your change