perf(flatkv): parallelize per-DB batch commit#3020
Merged
blindchaser merged 6 commits intomainfrom Mar 5, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
+ Coverage 58.39% 58.41% +0.01%
==========================================
Files 2110 2110
Lines 174991 175004 +13
==========================================
+ Hits 102192 102229 +37
+ Misses 63772 63753 -19
+ Partials 9027 9022 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+291
to
+294
| go func(idx int, db types.KeyValueDB) { | ||
| defer wg.Done() | ||
| errs[idx] = db.Flush() | ||
| }(i, db) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Comment on lines
+453
to
+456
| go func(idx int, b types.Batch) { | ||
| defer wg.Done() | ||
| errs[idx] = b.Commit(syncOpt) | ||
| }(i, p.batch) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
yzang2019
approved these changes
Mar 4, 2026
cody-littley
approved these changes
Mar 5, 2026
blindchaser
force-pushed
the
yiren/flatkv-commit
branch
from
a8a0cd3 to
cb78230
Compare
yzang2019
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Describe your changes and provide context ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change