Background Transaction Generation by cody-littley · Pull Request #3021 · sei-protocol/sei-chain

cody-littley · 2026-03-04T21:11:24Z

Describe your changes and provide context

Moved transaction generation off of the main benchmark thread for the cryptosim benchmark.

Testing performed to validate your change

Tested locally.

github-actions · 2026-03-04T21:12:23Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Mar 10, 2026, 7:26 PM

Signed-off-by: Cody Littley <cody.littley@seinetwork.io>

codecov · 2026-03-04T21:24:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.37%. Comparing base (285e643) to head (a6d3126).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
- Coverage   58.39%   58.37%   -0.02%     
==========================================
  Files        2080     2109      +29     
  Lines      171924   174801    +2877     
==========================================
+ Hits       100396   102045    +1649     
- Misses      62588    63733    +1145     
- Partials     8940     9023      +83

Flag	Coverage Δ
sei-db	`70.41% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.
see 105 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sei-db/state_db/bench/cryptosim/cryptosim_metrics.go

sei-db/state_db/bench/cryptosim/block_builder.go

blindchaser · 2026-03-05T23:10:33Z

sei-db/state_db/bench/cryptosim/block.go

+
+// This method should be called after a block is finished executing and finalized.
+// Reports metrics about the block.
+func (b *block) ReportBlockMetrcs() {


typo: Metrics

blindchaser · 2026-03-05T23:16:06Z

sei-db/state_db/bench/cryptosim/block.go

+}
+
+// Returns an iterator over the transactions in the block.
+func (b *block) Iterator() iter.Seq[*transaction] {


is this function get called?

I added this to avoid direct access to the block.transactions member variable, but forgot to actually use it. It is now used.

blindchaser · 2026-03-05T23:16:57Z

sei-db/state_db/bench/cryptosim/cryptosim_config.go

 	EnableSuspension bool
+
+	// The capacity of the channel that holds blocks awaiting execution.
+	BlockChannelCapacity int


optional: adding BlockChannelCapacity to Validate()

blindchaser · 2026-03-05T23:21:22Z

sei-db/state_db/bench/cryptosim/cryptosim.go

+
+	// Now that we are done generating initial data, it is thread safe to start the block builder.
+	// (dataGenerator is not thread safe, and is used both for initial setup and for transaction generation)
+	c.blockBuilder.Start()


not sure if this could. a problem, when blockBuilder.Start() is called. the blocker builder thread owns dataGenerator. but during suspend(), the main groutoutine reads from it, introduces concurrent access.

Good catch. Fixed.

yzang2019 · 2026-03-06T11:02:17Z

sei-db/state_db/bench/cryptosim/block.go

+}
+
+// Returns an iterator over the transactions in the block.
+func (b *block) Iterator() iter.Seq[*transaction] {


## Describe your changes and provide context Moved transaction generation off of the main benchmark thread for the cryptosim benchmark. ## Testing performed to validate your change Tested locally. --------- Signed-off-by: Cody Littley <cody.littley@seinetwork.io> Co-authored-by: Cody Littley <cody.littley@seinetwork.io>

## Summary The squash-merge of #3039 (`feat(flatkv): add read-only LoadVersion for state sync`) inadvertently reverted changes from 5 previously-merged PRs. The `yiren/flatkv-readonly` branch had accumulated stale versions of files through merge-from-main commits, and when the final squash-merge landed, those stale versions overwrote the newer code on `main`. ### PRs reverted by #3039 and restored in this PR | PR | Title | Key changes lost | |---|---|---| | **#2810** | fix(giga): check whether txs follow Giga ordering | `firstCosmosSeen` tx ordering check, `len(evmEntries) > 0` / `len(v2Entries) > 0` guards in `ProcessTXsWithOCCGiga` | | **#3035** | Add receiptdb config option in app.toml | `ReceiptStoreConfig` in app.toml, `readReceiptStoreConfig()`, `BackendTypeName()`, receipt config tests | | **#3043** | Add config to enable lattice hash | `EnableLatticeHash` config, composite store lattice hash support | | **#3021** | Background Transaction Generation | `block.go`, `block_builder.go` for cryptosim benchmark | | **#3046** | Add console logger and fix memiavl config for benchmark | `BlocksPerCommit=1`, `SnapshotInterval=1000`, `SnapshotMinTimeInterval=60` | ### Conflict resolutions Since several PRs landed after #3039 (notably #3050 slog migration, #3053 flaky test fix, #3062 admin service), cherry-picks required manual conflict resolution: - **`app/app.go`** (#2810): Kept #2810's structural changes, used `logger.Error` (from #3050) instead of `ctx.Logger().Error` - **`cmd/seid/cmd/app_config.go`** (#3035): Kept both `ReceiptStore` (from #3035) and `Admin` (from #3062) - **`sei-db/ledger_db/receipt/receipt_store.go`** (#3035): Restored `BackendTypeName` but dropped logger param (superseded by #3050 slog) - **`sei-db/ledger_db/receipt/parquet_store_test.go`** (#3035): Kept #3053's deterministic pruning test fix - **`sei-db/state_db/sc/composite/store_test.go`** (#3043): Merged all three needed imports - **`sei-db/common/logger/logger.go`** (#3046): Kept deletion from #3050; `consoleLogger` is no longer needed with slog - **`sei-db/state_db/bench/wrappers/db_implementations.go`** (#3046): Kept #3050's no-logger-param API --------- Signed-off-by: Cody Littley <cody.littley@seinetwork.io> Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com> Co-authored-by: Cody Littley <cody.littley@seinetwork.io>

## Describe your changes and provide context Moved transaction generation off of the main benchmark thread for the cryptosim benchmark. ## Testing performed to validate your change Tested locally. --------- Signed-off-by: Cody Littley <cody.littley@seinetwork.io> Co-authored-by: Cody Littley <cody.littley@seinetwork.io>

Cody Littley added 3 commits March 4, 2026 12:42

Show time spent per block.

086caeb

Handle block creation on background goroutine.

1386543

added missing files

8ecfba5

cody-littley requested review from blindchaser and yzang2019 March 4, 2026 21:11

cody-littley self-assigned this Mar 4, 2026

Cody Littley added 2 commits March 4, 2026 15:13

Merge branch 'main' into cody-littley/time-per-block

6fc55ba

adjust executor queue size

8938c6d

Signed-off-by: Cody Littley <cody.littley@seinetwork.io>

github-advanced-security bot found potential problems Mar 4, 2026

View reviewed changes

sei-db/state_db/bench/cryptosim/cryptosim_metrics.go Dismissed Show dismissed Hide dismissed

sei-db/state_db/bench/cryptosim/block_builder.go Dismissed Show dismissed Hide dismissed

cody-littley added the non-app-hash-breaking label Mar 5, 2026

lint

a7d0c54

blindchaser reviewed Mar 5, 2026

View reviewed changes

yzang2019 approved these changes Mar 6, 2026

View reviewed changes

Cody Littley added 2 commits March 6, 2026 08:14

Merge branch 'main' into cody-littley/time-per-block

dc531f4

made suggested changes

8674330

blindchaser approved these changes Mar 6, 2026

View reviewed changes

Merge branch 'main' into cody-littley/time-per-block

fc4ac1f

cody-littley enabled auto-merge (squash) March 10, 2026 17:41

cody-littley added 3 commits March 10, 2026 13:03

Merge branch 'main' into cody-littley/time-per-block

6605990

Merge branch 'main' into cody-littley/time-per-block

e13369a

Merge branch 'main' into cody-littley/time-per-block

a6d3126

cody-littley merged commit b7f2626 into main Mar 10, 2026
36 of 38 checks passed

cody-littley deleted the cody-littley/time-per-block branch March 10, 2026 20:51

blindchaser mentioned this pull request Mar 13, 2026

fix: restore PRs inadvertently reverted by #3039 squash-merge #3070

Merged

Conversation

cody-littley commented Mar 4, 2026

Describe your changes and provide context

Testing performed to validate your change

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Mar 4, 2026 •

edited

Loading

codecov bot commented Mar 4, 2026 •

edited

Loading