Create parent dirs for RocksDB backend fully#3022
Merged
Conversation
PebbleDB's Open internally calls MkdirAll to create the full directory tree, but RocksDB's CreateIfMissing only creates the leaf directory. This causes a panic when the EVM composite state store tries to open sub-databases at nested paths like evm_ss/nonce where the intermediate evm_ss/ directory doesn't exist yet. Normalize the behavior in the backend adapter so both backends work with arbitrary nested paths. Made-with: Cursor
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
yzang2019
approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
=======================================
Coverage 58.39% 58.39%
=======================================
Files 2110 2110
Lines 175009 175009
=======================================
Hits 102191 102191
Misses 63793 63793
Partials 9025 9025
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
blindchaser
approved these changes
Mar 4, 2026
Kbhat1
added a commit
that referenced
this pull request
Mar 4, 2026
## Describe your changes and provide context - For some rare cases where parent dirs are deleted, rocksdb doesn't use internal MkdirAll like what pebble does - Add back in ## Testing performed to validate your change - Verified fully on node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change