Source Go toolchain from official image and harden foundry install#3031
Merged
Source Go toolchain from official image and harden foundry install#3031
Conversation
- Add curl fail+retry flags for Go tarball download - Validate tarball before extraction - Retry when payload is not a valid gzip tar archive - Apply fix to both localnode and rpcnode Dockerfiles
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
- Remove inline curl/tar Go download from localnode and rpcnode Dockerfiles - Use multi-stage build with golang:1.25.6-bookworm and copy /usr/local/go - Eliminates flaky external tarball fetch during docker build
masih
changed the title
masih
changed the title
pompon0
approved these changes
Mar 6, 2026
mojtaba-esk
reviewed
Mar 6, 2026
| @@ -1,8 +1,10 @@ | |||
| FROM golang:1.25.6-bookworm AS go-dist | |||
mojtaba-esk
reviewed
Mar 6, 2026
| @@ -1,8 +1,10 @@ | |||
| FROM golang:1.25.6-bookworm AS go-dist | |||
|
|
|||
| FROM ubuntu:latest | |||
Contributor
There was a problem hiding this comment.
I know it is out of the scope of this PR, just want to share that I am not sure if using latest tag is the best idea here. To keep away from flakiness, we probably should use a fixed working version.
Collaborator
Author
There was a problem hiding this comment.
yup, also i do not love piping whatever fundary hosts into bash 😅
mojtaba-esk
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaked on main.