Merged
Conversation
`TestReadOnlyLoadVersionSoftFailsWhenFlatKVUnavailable` was intermittently failing because the default config uses asynchronous WAL writes. After `Commit()`, the test immediately opens a new WAL reader via `LoadVersion()` — but if the background write hasn't flushed yet, the reader sees an empty log and the store loads without any trees, causing a nil assertion failure. The race detector makes this much more likely by slowing goroutine scheduling. Set `AsyncCommitBuffer = 0` for this test so writes are synchronous . The test isn't exercising async behavior: it's testing the soft-fail path when FlatKV is unavailable.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3063 +/- ##
=======================================
Coverage 58.27% 58.27%
=======================================
Files 2076 2076
Lines 171480 171480
=======================================
Hits 99933 99933
Misses 62619 62619
Partials 8928 8928
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cody-littley
approved these changes
Mar 12, 2026
yzang2019
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestReadOnlyLoadVersionSoftFailsWhenFlatKVUnavailablewas intermittently failing because the default config uses asynchronous WAL writes. AfterCommit(), the test immediately opens a new WAL reader viaLoadVersion()— but if the background write hasn't flushed yet, the reader sees an empty log and the store loads without any trees, causing a nil assertion failure. The race detector makes this much more likely by slowing goroutine scheduling.Set
AsyncCommitBuffer = 0for this test so writes are synchronous . The test isn't exercising async behavior: it's testing the soft-fail path when FlatKV is unavailable.Flaked on main.