Added clone method to canned random#3076
Merged
cody-littley merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3076 +/- ##
==========================================
- Coverage 58.41% 58.41% -0.01%
==========================================
Files 2081 2081
Lines 171790 171790
==========================================
- Hits 100352 100351 -1
- Misses 62504 62505 +1
Partials 8934 8934
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
blindchaser
approved these changes
Mar 16, 2026
jewei1997
approved these changes
Mar 16, 2026
yzang2019
added a commit
that referenced
this pull request
Mar 16, 2026
* main: fix(giga): match v2 correctness checks (#3071) Added clone method to canned random (#3076) Helper files for the flatKV cache implementation (#3072) fix: restore PRs inadvertently reverted by #3039 squash-merge (#3070) Refine logging to avoid printing expensive objects on hot path (#3066) Fix flaky tendermint syncer test (#3065) Add runtime log level control via gRPC admin service (#3062) chore: dcoument run RPC suite on legacy vs giga (#3041) chore: self-contained revert tests, contract reorg, and failure analysis (#3033)
yzang2019
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Describe your changes and provide context In order to benchmark reads against the receipt store, we need a mechanism to get random numbers on other threads. The `CannedRandom` utility used by cryptosim is not currently thread safe. This PR adds a mechanism to generate random data on multiple threads safely. Co-authored-by: Cody Littley <cody.littley@seinetwork.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
In order to benchmark reads against the receipt store, we need a mechanism to get random numbers on other threads. The
CannedRandomutility used by cryptosim is not currently thread safe. This PR adds a mechanism to generate random data on multiple threads safely.