cryptosim bugfixes#3085
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
blindchaser
reviewed
Mar 18, 2026
| if found { | ||
| return fmt.Errorf("should not find source account in DB, account should be new") | ||
| } | ||
| srcAccountValue = txn.newSrcData |
Contributor
There was a problem hiding this comment.
the transaction struct still defines newSrcData and newDstData fields, and BuildTransaction() still allocates random byte slices into them
Contributor
Author
There was a problem hiding this comment.
removed unused fields
blindchaser
reviewed
Mar 18, 2026
| ) | ||
|
|
||
| /* | ||
| This extra binary for setting up logging is a an unfortunate complexity, but we can't really avoid it |
blindchaser
reviewed
Mar 18, 2026
| }() | ||
| } | ||
|
|
||
| func (m *CryptosimMetrics) startLogDirSizeSampling(logDir string, intervalSeconds int) { |
Contributor
There was a problem hiding this comment.
startLogDirSizeSampling() duplicates many code in startDataDirSizeSampling(), consider a common helper func?
Contributor
Author
There was a problem hiding this comment.
I've cleaned up the monitoring code setup.
blindchaser
reviewed
Mar 18, 2026
| @@ -141,20 +140,16 @@ func (txn *transaction) Execute( | |||
| phaseTimer.SetPhase("read_src_account") | |||
|
|
|||
| // Read the sender's native balance / nonce / codehash. | |||
Contributor
There was a problem hiding this comment.
comments outdated after the key prefix change to EVMKeyCodeHash
Contributor
Author
There was a problem hiding this comment.
Updated comment:
// Read the sender's native balance / nonce / codehash.
// Technically, we are just requesting to read the codehash, but internally the codehash is bundled with
// the nonce and balance, so all of this data will be read from low level storage, even if it isn't being
// returned to the caller.
_, found, err = database.Get(txn.srcAccount)
blindchaser
approved these changes
Mar 18, 2026
yzang2019
approved these changes
Mar 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
yzang2019
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Describe your changes and provide context Fixes two minor issues with the cryptosim benchmark: - logs are currently spamming the console - we are currently writing addresses to the storage DB instead of the address DB ## Testing performed to validate your change Ran cryptosim locally --------- Co-authored-by: Cody Littley <cody.littley@seinetwork.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Fixes two minor issues with the cryptosim benchmark:
Testing performed to validate your change
Ran cryptosim locally