Skip to content

chore(evmrpc): explicit unsupported rpcs#3086

Merged
mojtaba-esk merged 3 commits intomainfrom
mojtaba/evmrpc-explicit-unsupported-rpcs
Mar 19, 2026
Merged

chore(evmrpc): explicit unsupported rpcs#3086
mojtaba-esk merged 3 commits intomainfrom
mojtaba/evmrpc-explicit-unsupported-rpcs

Conversation

@mojtaba-esk
Copy link
Contributor

@mojtaba-esk mojtaba-esk commented Mar 18, 2026

Describe your changes and provide context

Expose several unimplemented Ethereum JSON-RPC methods on Sei so callers get -32000 and a clear error.message instead of -32601 (method not found)—same idea as eth_blobBaseFee.

Changes
debug_getRawBlock / Header / Receipts / Transaction, eth_newPendingTransactionFilter, eth_syncing → registered + ErrEVMNotSupported (evmrpc/rpc_unsupported.go).
eth_blobBaseFee → same error type as above.
Tests: unit + not-supported.iox fixtures; docs: docs/evm_jsonrpc_unsupported.md, evmrpc/AGENTS.md, README/analysis tables.

Testing performed to validate your change

go test ./evmrpc/...
evm_rpc_tests.sh / RPC IO suite (157 fixtures)

Related issues: PLT-159, PLT-160, PLT-167

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 19, 2026, 4:12 PM

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.55%. Comparing base (7a2287a) to head (ededa17).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
- Coverage   58.70%   58.55%   -0.16%     
==========================================
  Files        2093     2091       -2     
  Lines      172949   171912    -1037     
==========================================
- Hits       101538   100662     -876     
+ Misses      62426    62305     -121     
+ Partials     8985     8945      -40     
Flag Coverage Δ
sei-chain-pr 67.81% <100.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
evmrpc/filter.go 70.51% <100.00%> (+0.14%) ⬆️
evmrpc/info.go 77.68% <100.00%> (ø)
evmrpc/rpc_unsupported.go 100.00% <100.00%> (ø)
evmrpc/tracers.go 67.98% <100.00%> (+2.41%) ⬆️

... and 82 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebycarson
Copy link
Contributor

Looks good in theory on my end, I'll let someone on protocol eng give the stamp of approval though

@mojtaba-esk mojtaba-esk enabled auto-merge March 19, 2026 16:10
@mojtaba-esk mojtaba-esk added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 843a717 Mar 19, 2026
38 checks passed
@mojtaba-esk mojtaba-esk deleted the mojtaba/evmrpc-explicit-unsupported-rpcs branch March 19, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants