Skip to content

Fix IBC Upgrade Params#3092

Merged
masih merged 1 commit into
mainfrom
ibc-origin-main-param-migration
Mar 20, 2026
Merged

Fix IBC Upgrade Params#3092
masih merged 1 commit into
mainfrom
ibc-origin-main-param-migration

Conversation

@Kbhat1

@Kbhat1 Kbhat1 commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Describe your changes and provide context

  • Bump the IBC module consensus version
  • Initialize the new inbound/outbound params in migration so upgrades do not panic

Testing performed to validate your change

  • Unit tests
  • Verified full upgrade on node

Before

github.com/sei-protocol/sei-chain/sei-cosmos/x/upgrade.panicUpgradeNeeded({{_, _}, _, {_, _}, {_, _}, _, {_, _}, ...}, ...)
	/tmp/sei-upgrade/old-src/sei-cosmos/x/upgrade/abci.go:111 +0x1a0
github.com/sei-protocol/sei-chain/sei-cosmos/x/upgrade.BeginBlocker({{_, _}, _, {_, _}, {_, _}, _, {_, _}, ...}, ...)
	/tmp/sei-upgrade/old-src/sei-cosmos/x/upgrade/abci.go:68 +0x77c

After

time=2026-03-19T23:16:05.942-04:00 level=INFO msg="applying upgrade" logger=cosmos/x/upgrade name=v6.4.0 at="height: 51"
time=2026-03-19T23:16:05.942-04:00 level=INFO msg="migrating module from version to version" logger=cosmos/types/module module=ibc from-version=2 to-version=3

Query

$ seid q params subspace ibc InboundEnabled --output json
{"subspace":"ibc","key":"InboundEnabled","value":"true"}

$ seid q params subspace ibc OutboundEnabled --output json
{"subspace":"ibc","key":"OutboundEnabled","value":"true"}

Bump the IBC module consensus version and initialize the new inbound/outbound params in a dedicated migration so upgrades do not read missing param state.

Made-with: Cursor
@Kbhat1 Kbhat1 requested a review from philipsu522 March 20, 2026 03:01
@github-actions

github-actions Bot commented Mar 20, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 20, 2026, 3:02 AM

@Kbhat1 Kbhat1 requested a review from masih March 20, 2026 03:18
@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.72%. Comparing base (843a717) to head (77d8d26).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-ibc-go/modules/core/module.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3092   +/-   ##
=======================================
  Coverage   58.71%   58.72%           
=======================================
  Files        2094     2094           
  Lines      172972   172970    -2     
=======================================
+ Hits       101563   101569    +6     
+ Misses      62426    62417    -9     
- Partials     8983     8984    +1     
Flag Coverage Δ
sei-chain-pr 48.70% <71.42%> (?)
sei-db 70.41% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/upgrades.go 26.82% <ø> (+3.91%) ⬆️
sei-ibc-go/modules/core/keeper/migrations.go 50.00% <100.00%> (+50.00%) ⬆️
sei-ibc-go/modules/core/module.go 49.39% <50.00%> (-1.22%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 1ee46bf Mar 20, 2026
43 of 44 checks passed
@masih masih deleted the ibc-origin-main-param-migration branch March 20, 2026 09:18
github-actions Bot pushed a commit that referenced this pull request Mar 20, 2026
## Describe your changes and provide context
- Bump the IBC module consensus version
- Initialize the new inbound/outbound params in migration so upgrades do
not panic

## Testing performed to validate your change
- Unit tests
- Verified full upgrade on node

Before
```
github.com/sei-protocol/sei-chain/sei-cosmos/x/upgrade.panicUpgradeNeeded({{_, _}, _, {_, _}, {_, _}, _, {_, _}, ...}, ...)
	/tmp/sei-upgrade/old-src/sei-cosmos/x/upgrade/abci.go:111 +0x1a0
github.com/sei-protocol/sei-chain/sei-cosmos/x/upgrade.BeginBlocker({{_, _}, _, {_, _}, {_, _}, _, {_, _}, ...}, ...)
	/tmp/sei-upgrade/old-src/sei-cosmos/x/upgrade/abci.go:68 +0x77c
```

After
```
time=2026-03-19T23:16:05.942-04:00 level=INFO msg="applying upgrade" logger=cosmos/x/upgrade name=v6.4.0 at="height: 51"
time=2026-03-19T23:16:05.942-04:00 level=INFO msg="migrating module from version to version" logger=cosmos/types/module module=ibc from-version=2 to-version=3
```

Query
```
$ seid q params subspace ibc InboundEnabled --output json
{"subspace":"ibc","key":"InboundEnabled","value":"true"}

$ seid q params subspace ibc OutboundEnabled --output json
{"subspace":"ibc","key":"OutboundEnabled","value":"true"}
```

(cherry picked from commit 1ee46bf)
@seidroid

seidroid Bot commented Mar 20, 2026

Copy link
Copy Markdown

Successfully created backport PR for release/v6.4:

masih pushed a commit that referenced this pull request Mar 20, 2026
Backport of #3092 to `release/v6.4`.

Co-authored-by: Kartik Bhat <kartikbhatri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants