Skip to content

Disable zero copy for SC#3107

Merged
masih merged 2 commits intomainfrom
yzang/disable-zero-copy
Mar 21, 2026
Merged

Disable zero copy for SC#3107
masih merged 2 commits intomainfrom
yzang/disable-zero-copy

Conversation

@yzang2019
Copy link
Copy Markdown
Contributor

@yzang2019 yzang2019 commented Mar 21, 2026 •
edited
Loading

Describe your changes and provide context

This PR completely disable zero copy for SC to avoid segfault exception. It also reverts #3098

Testing performed to validate your change

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 21, 2026, 6:56 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.58%. Comparing base (6d0e8dc) to head (ca458d0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
- Coverage   58.58%   58.58%   -0.01%     
==========================================
  Files        2096     2096              
  Lines      173413   173408       -5     
==========================================
- Hits       101601   101596       -5     
  Misses      62757    62757              
  Partials     9055     9055
Flag Coverage Δ
sei-chain-pr 69.83% <100.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-cosmos/storev2/rootmulti/store.go 46.49% <ø> (-0.48%) ⬇️
sei-db/state_db/sc/memiavl/store.go 92.59% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih added this pull request to the merge queue Mar 21, 2026
Merged via the queue into main with commit b1cb904 Mar 21, 2026
41 of 42 checks passed
@masih masih deleted the yzang/disable-zero-copy branch March 21, 2026 20:48
github-actions bot pushed a commit that referenced this pull request Mar 21, 2026
@yzang2019 @masih @github-actions
Disable zero copy for SC (#3107)
1f5d94e 
## Describe your changes and provide context
This PR completely disable zero copy for SC to avoid segfault exception.
It also reverts #3098

## Testing performed to validate your change

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>
(cherry picked from commit b1cb904)
@seidroid seidroid bot mentioned this pull request Mar 21, 2026
Merged
@seidroid
Copy link
Copy Markdown

seidroid bot commented Mar 21, 2026

Successfully created backport PR for release/v6.4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masih masih masih approved these changes

@philipsu522 philipsu522 philipsu522 approved these changes

@blindchaser blindchaser Awaiting requested review from blindchaser

Assignees

No one assigned

Labels

backport release/v6.4 non-app-hash-breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yzang2019 @masih @philipsu522