fix: eth_call with eip-1559 call#3111
Merged
mojtaba-esk merged 4 commits intoMar 25, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
…parameter-compatibility
…3112) ## Describe your changes and provide context Fixes PLT-166 ## Testing performed to validate your change Co-authored-by: Mojtaba <mojtaba@celestia.org>
mojtaba-esk
commented
Mar 24, 2026
| @@ -1,3 +1,4 @@ | |||
| // Ethereum spec: eth_getLogs must return error (-32602) when block range extends beyond current head. Test fails if Sei returns result (e.g. []). | |||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
- Coverage 58.60% 58.57% -0.03%
==========================================
Files 2099 2098 -1
Lines 173514 173174 -340
==========================================
- Hits 101682 101445 -237
+ Misses 62776 62693 -83
+ Partials 9056 9036 -20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
amir-deris
approved these changes
Mar 24, 2026
| << {"jsonrpc":"2.0","id":1,"result":{}} | ||
| @ bind contractAddress = result.contractAddress | ||
| >> {"jsonrpc":"2.0","id":1,"method":"eth_call","params":[{"from":"0x0000000000000000000000000000000000000000","gas":"0xea60","input":"0x","maxFeePerGas":"0x5763d65","maxPriorityFeePerGas":"0xb","to":"${contractAddress}","value":"0x0"},"__SEED__"]} | ||
| >> {"jsonrpc":"2.0","id":1,"method":"eth_call","params":[{"from":"0x0000000000000000000000000000000000000000","gas":"0xea60","input":"0x","maxFeePerGas":"0x0","maxPriorityFeePerGas":"0x0","to":"${contractAddress}","value":"0x0"},"__SEED__"]} |
Contributor
There was a problem hiding this comment.
I was wondering does >> indicate input and << indicates expected output?
Contributor
There was a problem hiding this comment.
@amir-deris that's right. There is a parser for this in the package
…parameter-compatibility
mojtaba-esk
deleted the
mojtaba/fix-eth-call-with-eip-1559-call-env-parameter-compatibility
branch
jewei1997
pushed a commit
that referenced
this pull request
Mar 30, 2026
## Describe your changes and provide context EIP-1559-style `eth_call / eth_createAccessList` fixtures failed because Geth-style fee rules differ by path: tiny non-zero caps hit `fee cap < base fee`, large caps hit insufficient funds for `from=0x0`, and `createAccessList` rejects zero maxFeePerGas when both 1559 fields are set. This PR proposes an update to `call-callenv-options-eip1559.iox` to use maxFeePerGas / maxPriorityFeePerGas = 0x0 with from=0x0 ( eth_call / CallDefaults + NoBaseFee ). Also an update `create-al-contract-eip1559.iox` to bind from from the deploy receipt and use non-zero caps so `setFeeDefaults` and `BuyGas` succeed. It is also documented the split in fixture comments and refreshed [RPC_IO_README.md](https://github.com/sei-protocol/sei-chain/blob/5e967f4d1432e3f8b5e02d6dabb33611811b1211/integration_test/evm_module/rpc_io_test/RPC_IO_README.md) / [FAILED_TEST_ANALYSIS.md](https://github.com/sei-protocol/sei-chain/blob/5e967f4d1432e3f8b5e02d6dabb33611811b1211/integration_test/evm_module/rpc_io_test/FAILED_TEST_ANALYSIS.md) (incl. eth_call fix summary column, 147/12/92.5%). Fixes PLT-165 ## Testing performed to validate your change --------- Co-authored-by: Mojtaba <mojtaba@celestia.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
EIP-1559-style
eth_call / eth_createAccessListfixtures failed because Geth-style fee rules differ by path: tiny non-zero caps hitfee cap < base fee, large caps hit insufficient funds forfrom=0x0, andcreateAccessListrejects zero maxFeePerGas when both 1559 fields are set.This PR proposes an update to
call-callenv-options-eip1559.ioxto use maxFeePerGas / maxPriorityFeePerGas = 0x0 with from=0x0 ( eth_call / CallDefaults + NoBaseFee ). Also an updatecreate-al-contract-eip1559.ioxto bind from from the deploy receipt and use non-zero caps sosetFeeDefaultsandBuyGassucceed.It is also documented the split in fixture comments and refreshed RPC_IO_README.md / FAILED_TEST_ANALYSIS.md (incl. eth_call fix summary column, 147/12/92.5%).
Fixes PLT-165
Testing performed to validate your change