fix(evm-tests): align reverter_contract.hex with reverter.sol (solc 0.8.28)#3116
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
masih
approved these changes
Mar 25, 2026
amir-deris
approved these changes
Mar 25, 2026
jewei1997
pushed a commit
that referenced
this pull request
Mar 30, 2026
….8.28) (#3116) ## Describe your changes and provide context Regenerate `integration_test/evm_module/scripts/contracts/reverter_contract.hex` from `reverter.sol` using `solc 0.8.28` so the committed bytecode matches the source; document the compiler version in the .sol comment. Issue flagged by `#eng-cursor-bugbot` (hex did not match a proper compile of `reverter.sol`). ## Testing performed to validate your change The old blob was not solc output for `reverter.sol`, but it still implemented the same outward behavior the `.iox` files assert: revert with `Error("user error")` for empty / 0x01 calldata and a panic-style path for 0x02. so the test outcome did not change with this fix. Co-authored-by: Mojtaba <mojtaba@celestia.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Regenerate
integration_test/evm_module/scripts/contracts/reverter_contract.hexfromreverter.solusingsolc 0.8.28so the committed bytecode matches the source; document the compiler version in the .sol comment. Issue flagged by#eng-cursor-bugbot(hex did not match a proper compile ofreverter.sol).Testing performed to validate your change
The old blob was not solc output for
reverter.sol, but it still implemented the same outward behavior the.ioxfiles assert: revert withError("user error")for empty / 0x01 calldata and a panic-style path for 0x02.so the test outcome did not change with this fix.