Skip to content

InitChain cleanup#3121

Merged
pompon0 merged 12 commits into
mainfrom
gprusak-exe
Mar 26, 2026
Merged

InitChain cleanup#3121
pompon0 merged 12 commits into
mainfrom
gprusak-exe

Conversation

@pompon0

@pompon0 pompon0 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor
  • ResponseInitChain.ConsensusParams was never set
  • RequestInitChain.Validators was just compared against ResponseInitChain.Validators
  • Removed unused test helpers
  • Removed unused mocks
  • plain_types.go getters were unused
  • bunch of types in plain_types.go were unused
  • fixed misleading descriptions on InitGenesis of cosmos modules (whether they returned ValidatorUpdates)

@github-actions

github-actions Bot commented Mar 25, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 26, 2026, 7:21 PM

@pompon0 pompon0 requested a review from codchen March 25, 2026 21:25
@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.68%. Comparing base (d91ffb4) to head (f97c4c8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/consensus/replay.go 72.72% 3 Missing and 3 partials ⚠️
sei-tendermint/rpc/test/helpers.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3121      +/-   ##
==========================================
+ Coverage   58.39%   58.68%   +0.29%     
==========================================
  Files        2099     2099              
  Lines      173536   173254     -282     
==========================================
+ Hits       101334   101677     +343     
+ Misses      63156    62533     -623     
+ Partials     9046     9044       -2     
Flag Coverage Δ
sei-chain-pr 65.84% <78.94%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/test_helpers.go 63.30% <ø> (-0.09%) ⬇️
sei-cosmos/baseapp/abci.go 61.73% <100.00%> (+0.31%) ⬆️
sei-cosmos/x/genutil/module.go 48.07% <ø> (ø)
sei-cosmos/x/staking/module.go 62.66% <ø> (ø)
sei-ibc-go/testing/simapp/test_helpers.go 50.45% <ø> (-0.45%) ⬇️
sei-tendermint/abci/types/plain_types.go 28.57% <ø> (+22.74%) ⬆️
sei-tendermint/internal/state/execution.go 79.41% <100.00%> (+5.09%) ⬆️
sei-tendermint/test/e2e/app/app.go 0.00% <ø> (ø)
sei-tendermint/types/genesis.go 86.48% <100.00%> (+0.97%) ⬆️
sei-wasmd/app/test_helpers.go 41.89% <ø> (-0.23%) ⬇️
... and 3 more

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge March 26, 2026 19:19
@pompon0 pompon0 added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit c9b4295 Mar 26, 2026
40 of 41 checks passed
@pompon0 pompon0 deleted the gprusak-exe branch March 26, 2026 20:38
jewei1997 pushed a commit that referenced this pull request Mar 30, 2026
* ResponseInitChain.ConsensusParams was never set
* RequestInitChain.Validators was just compared against
ResponseInitChain.Validators
* Removed unused test helpers
* Removed unused mocks
* plain_types.go getters were unused
* bunch of types in plain_types.go were unused
* fixed misleading descriptions on InitGenesis of cosmos modules
(whether they returned ValidatorUpdates)

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants