Conversation
…vs eth_getBlockByNumber
…mber-returns-inconsistent-count-vs-eth_getBlockByNumber
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3125 +/- ##
==========================================
+ Coverage 58.72% 58.74% +0.01%
==========================================
Files 2094 2094
Lines 173166 173073 -93
==========================================
- Hits 101697 101667 -30
+ Misses 62412 62335 -77
- Partials 9057 9071 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bdchatham
reviewed
Mar 27, 2026
| return &cntHex | ||
| } | ||
|
|
||
| func countBlockTxsLikeEncodeTmBlock( |
There was a problem hiding this comment.
Would exporting this break something as opposed to creating the helper below that delegates?
Contributor
Author
There was a problem hiding this comment.
Not at all. just trying to hide the logic in an unexported func. and that exported is also to serve the evm_test which is another pkg.
bdchatham
approved these changes
Mar 27, 2026
masih
reviewed
Mar 27, 2026
amir-deris
approved these changes
Mar 27, 2026
…mber-returns-inconsistent-count-vs-eth_getBlockByNumber
masih
approved these changes
Mar 30, 2026
jewei1997
pushed a commit
that referenced
this pull request
Mar 30, 2026
…vs eth_getBlockByNumber (#3125) ## Describe your changes and provide context Context: [PLT-193](https://linear.app/seilabs/issue/PLT-193/bug-eth-getblocktransactioncountbynumber-returns-inconsistent-count-vs) Fixes PLT-193 ## Testing performed to validate your change --------- Co-authored-by: Mojtaba <mojtaba@celestia.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Context: PLT-193
Fixes PLT-193
Testing performed to validate your change