Skip to content

fix: eth_getBlockTransactionCountByNumber returns inconsistent count vs eth_getBlockByNumber#3125

Merged
masih merged 4 commits intomainfrom
mojtaba/fix-eth_getBlockTransactionCountByNumber-returns-inconsistent-count-vs-eth_getBlockByNumber
Mar 30, 2026
Merged

fix: eth_getBlockTransactionCountByNumber returns inconsistent count vs eth_getBlockByNumber#3125
masih merged 4 commits intomainfrom
mojtaba/fix-eth_getBlockTransactionCountByNumber-returns-inconsistent-count-vs-eth_getBlockByNumber

Conversation

@mojtaba-esk
Copy link
Copy Markdown
Contributor

Describe your changes and provide context

Context: PLT-193

Fixes PLT-193

Testing performed to validate your change

…mber-returns-inconsistent-count-vs-eth_getBlockByNumber
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 30, 2026, 6:08 AM

@mojtaba-esk mojtaba-esk requested a review from monty-sei March 27, 2026 12:03
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.74%. Comparing base (03ed612) to head (7285832).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
evmrpc/block.go 77.41% 6 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
+ Coverage   58.72%   58.74%   +0.01%     
==========================================
  Files        2094     2094              
  Lines      173166   173073      -93     
==========================================
- Hits       101697   101667      -30     
+ Misses      62412    62335      -77     
- Partials     9057     9071      +14     
Flag Coverage Δ
sei-chain-pr 67.83% <77.41%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
evmrpc/block.go 81.76% <77.41%> (+2.86%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

return &cntHex
}

func countBlockTxsLikeEncodeTmBlock(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would exporting this break something as opposed to creating the helper below that delegates?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all. just trying to hide the logic in an unexported func. and that exported is also to serve the evm_test which is another pkg.

@mojtaba-esk mojtaba-esk requested a review from masih March 27, 2026 14:47
…mber-returns-inconsistent-count-vs-eth_getBlockByNumber
@masih masih added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 600b896 Mar 30, 2026
39 checks passed
@masih masih deleted the mojtaba/fix-eth_getBlockTransactionCountByNumber-returns-inconsistent-count-vs-eth_getBlockByNumber branch March 30, 2026 12:39
jewei1997 pushed a commit that referenced this pull request Mar 30, 2026
…vs eth_getBlockByNumber (#3125)

## Describe your changes and provide context

Context:
[PLT-193](https://linear.app/seilabs/issue/PLT-193/bug-eth-getblocktransactioncountbynumber-returns-inconsistent-count-vs)

Fixes PLT-193

## Testing performed to validate your change

---------

Co-authored-by: Mojtaba <mojtaba@celestia.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants