Fix edge case for non atomic commit#3128
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
+ Coverage 58.51% 58.76% +0.24%
==========================================
Files 2095 2094 -1
Lines 173517 172918 -599
==========================================
+ Hits 101538 101612 +74
+ Misses 62866 62255 -611
+ Partials 9113 9051 -62
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
blindchaser
approved these changes
Mar 30, 2026
cody-littley
approved these changes
Mar 30, 2026
yzang2019
added a commit
that referenced
this pull request
Mar 31, 2026
* main: Fix edge case for non atomic commit (#3128)
blindchaser
pushed a commit
that referenced
this pull request
Apr 17, 2026
## Describe your changes and provide context This PR is intended to fix two issues: 1. Make sure lattice hash is enabled if write mode is Split Write. 2. If the node crashed during Commit after the cosmos store was committed but before the EVM/FlatKV one was, it will lead to an unrecovered mixed state with a wrong CommitInfo. The fix is to introduce some version reconciliation mechanism during initialization if the two DB version mismatch ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR is intended to fix two issues:
Testing performed to validate your change