Skip to content

fix to ProposalPOLMessage poisoning (CON-222)#3129

Merged
pompon0 merged 14 commits intomainfrom
gprusak-pol
Mar 30, 2026
Merged

fix to ProposalPOLMessage poisoning (CON-222)#3129
pompon0 merged 14 commits intomainfrom
gprusak-pol

Conversation

@pompon0
Copy link
Copy Markdown
Contributor

@pompon0 pompon0 commented Mar 27, 2026

The bug was about panic after setting vote at out of range index. Added a test. Additionally I have also made getters return bool to indicate if get succeeded.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 30, 2026, 3:06 PM

@pompon0 pompon0 enabled auto-merge March 27, 2026 16:10
@pompon0 pompon0 changed the title fix to ProposalPOLMessage poisoning fix to ProposalPOLMessage poisoning (CON-222) Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 59.22330% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.74%. Comparing base (03ed612) to head (cc418d3).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/consensus/state.go 33.33% 4 Missing and 4 partials ⚠️
sei-tendermint/types/vote_set.go 56.25% 5 Missing and 2 partials ⚠️
sei-tendermint/types/block.go 53.84% 3 Missing and 3 partials ⚠️
...tendermint/internal/consensus/types/round_state.go 33.33% 2 Missing and 2 partials ⚠️
sei-tendermint/types/validation.go 66.66% 2 Missing and 2 partials ⚠️
sei-tendermint/internal/evidence/verify.go 40.00% 1 Missing and 2 partials ⚠️
sei-tendermint/test/e2e/runner/evidence.go 0.00% 3 Missing ⚠️
sei-tendermint/types/evidence.go 57.14% 1 Missing and 2 partials ⚠️
sei-tendermint/types/part_set.go 33.33% 1 Missing and 1 partial ⚠️
sei-tendermint/node/setup.go 66.66% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3129      +/-   ##
==========================================
+ Coverage   58.72%   58.74%   +0.01%     
==========================================
  Files        2094     2094              
  Lines      173166   173193      +27     
==========================================
+ Hits       101697   101734      +37     
+ Misses      62412    62392      -20     
- Partials     9057     9067      +10     
Flag Coverage Δ
sei-chain-pr 63.68% <59.22%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-ibc-go/testing/chain.go 94.04% <100.00%> (ø)
sei-tendermint/internal/consensus/msgs.go 81.60% <ø> (ø)
sei-tendermint/internal/consensus/peer_state.go 87.50% <100.00%> (+3.01%) ⬆️
sei-tendermint/internal/consensus/reactor.go 71.65% <100.00%> (+2.69%) ⬆️
...rmint/internal/consensus/types/peer_round_state.go 100.00% <ø> (ø)
sei-tendermint/internal/rpc/core/status.go 81.01% <100.00%> (ø)
sei-tendermint/types/proposal.go 85.71% <100.00%> (ø)
sei-tendermint/types/validator_set.go 93.10% <100.00%> (ø)
sei-tendermint/node/setup.go 67.03% <66.66%> (ø)
sei-wasmd/x/wasm/ibctesting/chain.go 68.51% <0.00%> (-0.31%) ⬇️
... and 9 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 requested a review from wen-coding March 30, 2026 10:00
@pompon0 pompon0 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit d201e89 Mar 30, 2026
39 checks passed
@pompon0 pompon0 deleted the gprusak-pol branch March 30, 2026 15:39
@seidroid
Copy link
Copy Markdown

seidroid bot commented Mar 30, 2026

Created backport PR for release/v6.3:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-3129-to-release/v6.3
git worktree add --checkout .worktree/backport-3129-to-release/v6.3 backport-3129-to-release/v6.3
cd .worktree/backport-3129-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x d201e89ad5f867eea4e275b6d4ec5b80e5cf6afc
git push --force-with-lease

github-actions bot pushed a commit that referenced this pull request Mar 30, 2026
The bug was about panic after setting vote at out of range index. Added
a test. Additionally I have also made getters return bool to indicate if
get succeeded.

(cherry picked from commit d201e89)
@seidroid
Copy link
Copy Markdown

seidroid bot commented Mar 30, 2026

Successfully created backport PR for release/v6.4:

jewei1997 pushed a commit that referenced this pull request Mar 30, 2026
The bug was about panic after setting vote at out of range index. Added
a test. Additionally I have also made getters return bool to indicate if
get succeeded.
masih added a commit that referenced this pull request Mar 31, 2026
#3139)

Backport of #3129 to `release/v6.4`.

---------

Co-authored-by: Grzegorz Prusak <pompon.pompon@gmail.com>
Co-authored-by: Masih H. Derkani <m@derkani.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants