Eliminate per-iteration allocation in SetEvmOnlyBlockBloom#3133
Merged
Conversation
ORBytes supports in-place operation where the destination overlaps
with a source, so we can OR directly into blockBloom instead of
allocating a temporary slice on every loop iteration.
│ Before │ After
│ sec/op │ sec/op vs base
SetEvmOnlyBlockBloom-12 6.890µ ± 0% 5.658µ ± 0% -17.88%
│ Before │ After
│ B/op │ B/op vs base
SetEvmOnlyBlockBloom-12 12.80Ki ± 0% 0.000 ± 0% -100.00%
│ Before │ After
│ allocs/op │ allocs/op vs base
SetEvmOnlyBlockBloom-12 50.00 ± 0% 0.00 ± 0% -100.00%
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3133 +/- ##
==========================================
- Coverage 58.75% 58.72% -0.03%
==========================================
Files 2095 2094 -1
Lines 173543 173021 -522
==========================================
- Hits 101961 101603 -358
+ Misses 62469 62358 -111
+ Partials 9113 9060 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Mar 30, 2026
arajasek
approved these changes
Mar 30, 2026
amir-deris
approved these changes
Mar 30, 2026
yzang2019
added a commit
that referenced
this pull request
Mar 31, 2026
* main: fix(flatkv): harden error handling for readonly store and crash cleanup (#3127) Remove redundant makefiles, unused code and adjust docs (#3149) Fix minor logging issues (#3147) PLT-225 Use in place orbytes for bloom filter (#3144) Eliminate per-iteration allocation in SetEvmOnlyBlockBloom (#3133)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ORBytes supports in-place operation where the destination overlaps with a source, so we can OR directly into blockBloom instead of allocating a temporary slice on every loop iteration.