Skip to content

Deflake empty-block in mempool test#3137

Merged
masih merged 5 commits into
mainfrom
masih/deflake-mempool-test
Mar 30, 2026
Merged

Deflake empty-block in mempool test#3137
masih merged 5 commits into
mainfrom
masih/deflake-mempool-test

Conversation

@masih

@masih masih commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

TestMempoolProgressAfterCreateEmptyBlocksInterval used the same 5s value for CreateEmptyBlocksInterval and for the helper that requires the next event to arrive before timing out. After spending one full ensureTimeout asserting that no early block was produced, the test only gave the next empty block another ensureTimeout to be proposed, committed and published. On slower CI runners that boundary is tight enough for the helper to fire before the NewBlock event is delivered, even though consensus behavior is correct.

Fix that test by waiting for the exact next NewBlock height with the existing eventual helper. The test still asserts that no block is created during the full empty-block interval, and it now additionally checks that the next block is exactly the expected height.

Flaked in unrelated changes.

TestMempoolProgressAfterCreateEmptyBlocksInterval used the same 5s value
for CreateEmptyBlocksInterval and for the helper that requires the next
event to arrive before timing out. After spending one full ensureTimeout
asserting that no early block was produced, the test only gave the next
empty block another ensureTimeout to be proposed, committed and published.
On slower CI runners that boundary is tight enough for the helper to fire
before the NewBlock event is delivered, even though consensus behavior is
correct.

Fix that test by waiting for the exact next NewBlock height with the
existing eventual helper. The test still asserts that no block is created
during the full empty-block interval, and it now additionally checks that
the next block is exactly the expected height.
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 30, 2026, 6:37 PM

@masih masih enabled auto-merge March 30, 2026 14:55
@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.74%. Comparing base (95ed1f5) to head (3cefaba).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3137   +/-   ##
=======================================
  Coverage   58.73%   58.74%           
=======================================
  Files        2095     2095           
  Lines      173517   173517           
=======================================
+ Hits       101920   101928    +8     
+ Misses      62481    62476    -5     
+ Partials     9116     9113    -3     
Flag Coverage Δ
sei-chain-pr 68.61% <ø> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 96fbde3 Mar 30, 2026
39 checks passed
@masih masih deleted the masih/deflake-mempool-test branch March 30, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants