State Store Wrapper ApplychangesetAsync#3142
Merged
Merged
Conversation
Use ApplyChangesetAsync for the cryptosim state-store wrapper while preserving immediate read and historical-state behavior by waiting for pending writes before advancing the visible version. Made-with: Cursor
Align the state-store benchmark wrapper with the simpler async apply pattern by advancing the wrapper version after enqueuing the changeset and validating persisted historical reads after reopen. Made-with: Cursor
Use the same atomic Add(1) version advancement pattern as combined_wrapper while keeping the async apply path for the state-store benchmark wrapper. Made-with: Cursor
yzang2019
approved these changes
Mar 30, 2026
Resolve the state_store_wrapper conflict by keeping the new changelog-entry interface from main and preserving the branch's async state-store apply behavior. Made-with: Cursor
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
cody-littley
approved these changes
Mar 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
==========================================
+ Coverage 58.71% 58.73% +0.02%
==========================================
Files 2095 2095
Lines 173517 173517
==========================================
+ Hits 101882 101920 +38
+ Misses 62516 62481 -35
+ Partials 9119 9116 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Update the wrapper test to assert the async apply path so it matches the intended state store wrapper behavior. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change