fix: sei legacy http batch#3160
Merged
Merged
Conversation
mojtaba-esk
added
non-app-hash-breaking
backport release/v6.4
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3160 +/- ##
========================================
Coverage 58.75% 58.76%
========================================
Files 2095 2095
Lines 173551 173665 +114
========================================
+ Hits 101965 102046 +81
- Misses 62465 62492 +27
- Partials 9121 9127 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mojtaba-esk
changed the title
sei-will
approved these changes
Apr 2, 2026
masih
approved these changes
Apr 2, 2026
| // seiLegacyHTTPMaxBody matches github.com/ethereum/go-ethereum/rpc.defaultBodyLimit (5MiB), the | ||
| // default HTTP request body cap used by rpc.Server before ServeHTTP. The legacy gate must not | ||
| // read more than the inner JSON-RPC stack will accept (see rpc.Server.SetHTTPBodyLimit). | ||
| const seiLegacyHTTPMaxBody = 5 * 1024 * 1024 |
Collaborator
There was a problem hiding this comment.
FWIW i find the << trick to be easer to read ( but that's just me)
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-3160-to-release/v6.4
git worktree add --checkout .worktree/backport-3160-to-release/v6.4 backport-3160-to-release/v6.4
cd .worktree/backport-3160-to-release/v6.4
git reset --hard HEAD^
git cherry-pick -x d3f22bde2f0d9d9b4c758a2a785f2a208d8f3932
git push --force-with-lease |
masih
added a commit
that referenced
this pull request
Apr 2, 2026
Backport of #3160 to `release/v6.4`. --------- Co-authored-by: Moji <mojtaba-esk@users.noreply.github.com> Co-authored-by: Masih H. Derkani <m@derkani.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Context: PLT-227
Fixes PLT-227
Testing performed to validate your change