Fix gzip double-close in EVM JSON-RPC responses#3176
Merged
Conversation
When an HTTP response has Content-Length set, gzipResponseWriter.Write() closes the gzip stream early to ensure the footer is flushed. However, the deferred close() then calls gz.Close() a second time, writing a duplicate gzip footer and producing a corrupted stream. Clients fail with Z_DATA_ERROR when decompressing. Return the gzip writer to the pool and nil-out the reference in Write() so the deferred close() becomes a no-op.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
bdchatham
approved these changes
Apr 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
=======================================
Coverage 58.67% 58.67%
=======================================
Files 2055 2055
Lines 168425 168427 +2
=======================================
+ Hits 98815 98817 +2
Misses 60796 60796
Partials 8814 8814
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Apr 2, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
When an HTTP response has Content-Length set, gzipResponseWriter.Write() closes the gzip stream early to ensure the footer is flushed. However, the deferred close() then calls gz.Close() a second time, writing a duplicate gzip footer and producing a corrupted stream. Clients fail with Z_DATA_ERROR when decompressing. Return the gzip writer to the pool and nil-out the reference in Write() so the deferred close() becomes a no-op. (cherry picked from commit 2c00c3d)
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an HTTP response has Content-Length set, gzipResponseWriter.Write() closes the gzip stream early to ensure the footer is flushed. However, the deferred close() then calls gz.Close() a second time, writing a duplicate gzip footer and producing a corrupted stream. Clients fail with Z_DATA_ERROR when decompressing.
Return the gzip writer to the pool and nil-out the reference in Write() so the deferred close() becomes a no-op.