Skip to content

proto conversion defensive tests (CON-240)#3206

Merged
pompon0 merged 5 commits into
mainfrom
gprusak-proto-test
Apr 8, 2026
Merged

proto conversion defensive tests (CON-240)#3206
pompon0 merged 5 commits into
mainfrom
gprusak-proto-test

Conversation

@pompon0

@pompon0 pompon0 commented Apr 7, 2026

Copy link
Copy Markdown
Contributor
  • I've updated ProtoConv test to check if Decode does not panic on malformed proto messages (with missing fields). Decode expects the argument to be non-nil, but its fields are not guaranteed to be non-nil. Slices representing repeated values are guaranteed to contain non-nil values though.
  • fixed TimeoutQC logic to disallow empty QCs.

@pompon0 pompon0 requested review from sei-will and wen-coding April 7, 2026 17:25
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 7, 2026, 6:09 PM

@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.11111% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.85%. Comparing base (9218c01) to head (fdc362c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/protoutils/testonly.go 64.51% 7 Missing and 4 partials ⚠️
sei-tendermint/internal/autobahn/types/timeout.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3206      +/-   ##
==========================================
+ Coverage   58.77%   58.85%   +0.07%     
==========================================
  Files        2055     2055              
  Lines      168498   168531      +33     
==========================================
+ Hits        99039    99193     +154     
+ Misses      60708    60637      -71     
+ Partials     8751     8701      -50     
Flag Coverage Δ
sei-chain-pr 80.96% <71.11%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/autobahn/types/block.go 83.62% <100.00%> (+17.24%) ⬆️
sei-tendermint/internal/autobahn/types/msg.go 81.63% <100.00%> (+8.16%) ⬆️
sei-tendermint/internal/autobahn/types/proposal.go 91.45% <100.00%> (+9.12%) ⬆️
sei-tendermint/internal/p2p/conv.go 88.52% <ø> (+9.83%) ⬆️
sei-tendermint/internal/autobahn/types/timeout.go 78.66% <66.66%> (+3.32%) ⬆️
sei-tendermint/internal/protoutils/testonly.go 59.52% <64.51%> (+14.06%) ⬆️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 8d751f6 Apr 8, 2026
39 checks passed
@pompon0 pompon0 deleted the gprusak-proto-test branch April 8, 2026 09:21
@pompon0 pompon0 changed the title proto conversion defensive tests proto conversion defensive tests (CON-240) Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants