Skip to content

mux stream kind mismatch fix (CON-240)#3209

Merged
pompon0 merged 13 commits into
mainfrom
gprusak-proto-test
Apr 10, 2026
Merged

mux stream kind mismatch fix (CON-240)#3209
pompon0 merged 13 commits into
mainfrom
gprusak-proto-test

Conversation

@pompon0

@pompon0 pompon0 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Made mux stream opening more strict:

  • explicit kind when OPEN frame
  • kind mismatch is detected instead of ignored
    Added relevant tests.

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 10, 2026, 10:00 AM

@pompon0 pompon0 requested review from sei-will and wen-coding April 8, 2026 10:52
@codecov

codecov Bot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.79%. Comparing base (8d751f6) to head (34ee54a).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/p2p/mux/mux.go 77.77% 1 Missing and 1 partial ⚠️
sei-tendermint/internal/p2p/mux/stream_state.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3209   +/-   ##
=======================================
  Coverage   58.79%   58.79%           
=======================================
  Files        2054     2054           
  Lines      168303   168305    +2     
=======================================
+ Hits        98948    98952    +4     
+ Misses      60609    60608    -1     
+ Partials     8746     8745    -1     
Flag Coverage Δ
sei-chain-pr 79.60% <72.72%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/p2p/mux/stream_state.go 91.66% <50.00%> (+4.16%) ⬆️
sei-tendermint/internal/p2p/mux/mux.go 77.77% <77.77%> (+0.19%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 changed the title mux stream kind mismatch fix mux stream kind mismatch fix (CON-240) Apr 8, 2026
Comment thread sei-tendermint/internal/p2p/mux/mux_test.go Outdated
Comment thread sei-tendermint/internal/p2p/mux/mux_test.go Outdated
Comment thread sei-tendermint/internal/p2p/mux/mux_test.go Outdated
pompon0 and others added 3 commits April 10, 2026 11:57
Co-authored-by: Wen <113942165+wen-coding@users.noreply.github.com>
Co-authored-by: Wen <113942165+wen-coding@users.noreply.github.com>
Co-authored-by: Wen <113942165+wen-coding@users.noreply.github.com>
@pompon0 pompon0 enabled auto-merge April 10, 2026 09:58
@pompon0 pompon0 added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 107c8e7 Apr 10, 2026
39 checks passed
@pompon0 pompon0 deleted the gprusak-proto-test branch April 10, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants