fix: return zero value for Int, Uint, and Dec when unmarshalling empty bytes#3221
Merged
masih merged 2 commits intoApr 10, 2026
Conversation
…arshalling empty bytes
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
+ Coverage 59.00% 59.26% +0.26%
==========================================
Files 2065 2065
Lines 169422 169410 -12
==========================================
+ Hits 99959 100398 +439
+ Misses 60700 60261 -439
+ Partials 8763 8751 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bdchatham
approved these changes
Apr 9, 2026
masih
approved these changes
Apr 10, 2026
…n-Int-Uint-Dec-Unmarshal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
Int,Uint, orDecprotobufUnmarshalmethods received an empty byte slice, they returned without initializing the underlying*big.Int, leaving the struct in a nil/invalid state. This would cause panics on subsequent operations likeEqual(), arithmetic, etc.Fix
Return the proper zero value (
ZeroInt(),ZeroUint(),ZeroDec()) when the input data is empty, rather than leaving the struct uninitialized.Files Changed
sei-cosmos/types/int.go—Int.Unmarshalsei-cosmos/types/uint.go—Uint.Unmarshalsei-cosmos/types/decimal.go—Dec.Unmarshal