Skip to content

Assert that forked upstream dependencies are absent#3226

Merged
masih merged 2 commits into
mainfrom
masih/harden-go-mod-req
Apr 10, 2026
Merged

Assert that forked upstream dependencies are absent#3226
masih merged 2 commits into
mainfrom
masih/harden-go-mod-req

Conversation

@masih

@masih masih commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Sei forked a set of upstream dependencies, and all of those are flattened into a single go module.

Depending on the remote ones is almost certainly a programmer error. Assert that they are absent to avoid accidental external dependency.

Sei forked a set of upstream dependencies, and all of those are
flattened into a single go module.

Depending on the remote ones is almost certainly a programmer error.
Assert that they are absent to avoid accidental external dependency.
@masih masih requested review from bdchatham and sei-will April 10, 2026 13:44
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 10, 2026, 1:46 PM

@codecov

codecov Bot commented Apr 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.02%. Comparing base (107c8e7) to head (424f43d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
- Coverage   59.03%   59.02%   -0.01%     
==========================================
  Files        2065     2065              
  Lines      169424   169413      -11     
==========================================
- Hits       100021   100001      -20     
- Misses      60653    60659       +6     
- Partials     8750     8753       +3     
Flag Coverage Δ
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih enabled auto-merge April 10, 2026 13:46
@masih masih added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 94a1abf Apr 10, 2026
39 checks passed
@masih masih deleted the masih/harden-go-mod-req branch April 10, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants