strongly typed clist#3249
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3249 +/- ##
==========================================
+ Coverage 58.56% 59.39% +0.82%
==========================================
Files 2072 2072
Lines 208020 171562 -36458
==========================================
- Hits 121833 101895 -19938
+ Misses 77413 60925 -16488
+ Partials 8774 8742 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| next, err := r.evpool.WaitEvidenceFront(ctx) | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to convert evidence: %w", err)) | ||
| return |
There was a problem hiding this comment.
nit: Should we return error some day?
There was a problem hiding this comment.
not necessarily, since the error will be always context.Canceled/DeadlineExceeded here. TBD
| // Deprecated and should be removed in 0.37 | ||
| func (env *Environment) BroadcastTxAsync(ctx context.Context, req *coretypes.RequestBroadcastTx) (*coretypes.ResultBroadcastTx, error) { | ||
| go func() { _ = env.Mempool.CheckTx(ctx, req.Tx, nil, mempool.TxInfo{}) }() | ||
| go func() { _, _ = env.Mempool.CheckTx(ctx, req.Tx, mempool.TxInfo{}) }() |
There was a problem hiding this comment.
This ctx is the request context right? Will it be cancelled once the request is done? Then we run CheckTX in a canclled context?
There was a problem hiding this comment.
CheckTx in sei-chain/app/abci.go is not blocking, so it ignores the fact that context is cancelled. Context is used for tracing though.
| peerMempoolID := r.ids.GetForPeer(peerID) | ||
| // TODO: this function does not call any external code, so panics should not be expected. | ||
| defer func() { | ||
| if e := recover(); e != nil { |
There was a problem hiding this comment.
Do we not need this recover() any more?
There was a problem hiding this comment.
afaict this code is safe now. There is no interface calls which would be allowed to panic.
3 participants
Made clist generic. Also