Fix buffer offset in ProposerPriorityHash (CON-200)#3255
Merged
wen-coding merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
binary.PutVarint was always writing to buf[0:] instead of advancing the offset, so each validator overwrote the previous one. Write to buf[offset:] so all validators contribute to the hash. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
- Coverage 59.28% 59.25% -0.03%
==========================================
Files 2070 2070
Lines 169775 169704 -71
==========================================
- Hits 100655 100563 -92
- Misses 60328 60340 +12
- Partials 8792 8801 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Apr 15, 2026
yzang2019
approved these changes
Apr 16, 2026
yzang2019
added a commit
that referenced
this pull request
Apr 16, 2026
* main: Fix buffer offset in ProposerPriorityHash (CON-200) (#3255) Handle error case in light client divergence detector (#3254) perf(evmrpc): eliminate redundant block fetches in simulate backend (#3208) fix(evmrpc): omit notifications from legacy JSON-RPC batch responses per spec (#3246) fix: deduplicate block fetch in getTransactionReceipt (#3244)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binary.PutVarintwriting tobuf[0:]on every iteration instead of advancing the write positionTest plan
go vet ./sei-tendermint/types/...passesgo test ./sei-tendermint/types/...passes