Backport release/v6.4: Handle error case in light client divergence detector#3282
Merged
wen-coding merged 2 commits intorelease/v6.4from Apr 21, 2026
Merged
Backport release/v6.4: Handle error case in light client divergence detector#3282wen-coding merged 2 commits intorelease/v6.4from
release/v6.4: Handle error case in light client divergence detector#3282wen-coding merged 2 commits intorelease/v6.4from
Conversation
## Summary - Add missing error type handling in `detectDivergence` switch statement in the light client detector - Previously this error fell through to the default case and was silently logged instead of being returned ## Test plan - [x] `go build ./sei-tendermint/light/...` passes - [x] `go test ./sei-tendermint/light/...` passes --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit de50195)
2 tasks
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v6.4 #3282 +/- ##
================================================
- Coverage 58.35% 58.35% -0.01%
================================================
Files 2091 2091
Lines 173004 172964 -40
================================================
- Hits 100963 100934 -29
+ Misses 63027 63019 -8
+ Partials 9014 9011 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
pompon0
approved these changes
Apr 21, 2026
wen-coding
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3254 to
release/v6.4.