Skip to content

avoid early bail out in migration manager#3322

Merged
cody-littley merged 4 commits into
mainfrom
cjl/STO-502
Apr 30, 2026
Merged

avoid early bail out in migration manager#3322
cody-littley merged 4 commits into
mainfrom
cjl/STO-502

Conversation

@cody-littley

Copy link
Copy Markdown
Contributor

Describe your changes and provide context

Don't bail out early in the migration manager if the context gets cancelled.

Testing performed to validate your change

unit test coverage

@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 30, 2026, 7:22 PM

@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 27, 2026, 7:36 PM

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.17%. Comparing base (f31742f) to head (4c77802).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3322      +/-   ##
==========================================
- Coverage   59.18%   59.17%   -0.01%     
==========================================
  Files        2097     2094       -3     
  Lines      172489   171628     -861     
==========================================
- Hits       102092   101566     -526     
+ Misses      61542    61268     -274     
+ Partials     8855     8794      -61     
Flag Coverage Δ
sei-chain-pr 80.69% <ø> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-db/state_db/sc/migration/migration_manager.go 96.13% <ø> (-0.04%) ⬇️

... and 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cody-littley cody-littley added this pull request to the merge queue Apr 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Apr 29, 2026
@cody-littley cody-littley added this pull request to the merge queue Apr 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Apr 29, 2026
@cody-littley cody-littley enabled auto-merge April 30, 2026 19:21
@cody-littley cody-littley added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit 5b671ef Apr 30, 2026
38 checks passed
@cody-littley cody-littley deleted the cjl/STO-502 branch April 30, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants