Skip to content

Backport release/v6.4: fix(evmrpc): return empty array instead of null for eth_getFilterLogs and eth_getFilterChanges#3324

Open
seidroid[bot] wants to merge 3 commits intorelease/v6.4from
backport-3292-to-release/v6.4
Open

Backport release/v6.4: fix(evmrpc): return empty array instead of null for eth_getFilterLogs and eth_getFilterChanges#3324
seidroid[bot] wants to merge 3 commits intorelease/v6.4from
backport-3292-to-release/v6.4

Conversation

@seidroid
Copy link
Copy Markdown

@seidroid seidroid Bot commented Apr 28, 2026

Backport of #3292 to release/v6.4.

@seidroid
Copy link
Copy Markdown
Author

seidroid Bot commented Apr 28, 2026

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-3292-to-release/v6.4
git worktree add --checkout .worktree/backport-3292-to-release/v6.4 backport-3292-to-release/v6.4
cd .worktree/backport-3292-to-release/v6.4
git reset --hard HEAD^
git cherry-pick -x 0ad5733844536ef11c057e5624bb3e949c99cb9a
git push --force-with-lease

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 28, 2026, 5:10 PM

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.36%. Comparing base (ffb1523) to head (95f0c18).

Files with missing lines Patch % Lines
evmrpc/filter.go 18.18% 7 Missing and 2 partials ⚠️
evmrpc/rpc_unsupported.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.4    #3324      +/-   ##
================================================
- Coverage         58.36%   58.36%   -0.01%     
================================================
  Files              2091     2092       +1     
  Lines            173022   173034      +12     
================================================
+ Hits             100983   100988       +5     
- Misses            63045    63052       +7     
  Partials           8994     8994              
Flag Coverage Δ
sei-chain-pr 63.23% <13.33%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
evmrpc/rpc_unsupported.go 0.00% <0.00%> (ø)
evmrpc/filter.go 69.44% <18.18%> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih marked this pull request as ready for review April 28, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant