Skip to content

testfix: delayed WAL closing#3327

Merged
pompon0 merged 3 commits into
mainfrom
gprusak-wal-tests
Apr 28, 2026
Merged

testfix: delayed WAL closing#3327
pompon0 merged 3 commits into
mainfrom
gprusak-wal-tests

Conversation

@pompon0

@pompon0 pompon0 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

When consensus WAL is closed while consensus is running, some of the messages might get dropped (handler panics -> processing loop recovers the panic and continues). The solution is to close WAL only once consensus state Run() terminates. Also this recover seems to be dangerous itself (because of recover), will investigate in a separate pr.

also refactored a bunch of functions to be methods of testState which is now a wrapper of State, which also acts as a handler of bunch of goroutines operating on the State.

THE ACTUAL FLAKINESS FIX is included in this pr, but it is not related to the WAL closing error logs. The problem was due to constructing a proposal in the wrong consensus round.

@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 28, 2026, 2:42 PM

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.19%. Comparing base (d67dd88) to head (0c439a2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
- Coverage   59.19%   59.19%   -0.01%     
==========================================
  Files        2097     2097              
  Lines      172482   172477       -5     
==========================================
- Hits       102106   102101       -5     
  Misses      61532    61532              
  Partials     8844     8844              
Flag Coverage Δ
sei-chain-pr 68.78% <ø> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/consensus/state.go 75.48% <ø> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit 8c44d05 Apr 28, 2026
39 checks passed
@pompon0 pompon0 deleted the gprusak-wal-tests branch April 28, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants