testfix: delayed WAL closing#3327
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
==========================================
- Coverage 59.19% 59.19% -0.01%
==========================================
Files 2097 2097
Lines 172482 172477 -5
==========================================
- Hits 102106 102101 -5
Misses 61532 61532
Partials 8844 8844
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Apr 28, 2026
wen-coding
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When consensus WAL is closed while consensus is running, some of the messages might get dropped (handler panics -> processing loop recovers the panic and continues). The solution is to close WAL only once consensus state Run() terminates. Also this recover seems to be dangerous itself (because of recover), will investigate in a separate pr.
also refactored a bunch of functions to be methods of testState which is now a wrapper of State, which also acts as a handler of bunch of goroutines operating on the State.
THE ACTUAL FLAKINESS FIX is included in this pr, but it is not related to the WAL closing error logs. The problem was due to constructing a proposal in the wrong consensus round.