Skip to content

Wait for new-round events before injecting test proposals#3330

Merged
masih merged 2 commits into
mainfrom
masih/tm-deflake-wait-for-rounds
Apr 28, 2026
Merged

Wait for new-round events before injecting test proposals#3330
masih merged 2 commits into
mainfrom
masih/tm-deflake-wait-for-rounds

Conversation

@masih

@masih masih commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Several consensus tests enqueue round-N proposals before the state machine has observed the transition into round N. Under -race, those queued messages can be handled while the state is still in the previous round, so SetProposal drops the proposal and the test later times out waiting for the CompleteProposal event.

Synchronizing on the NewRound event before calling SetProposalAndBlock makes the test order match the state machine's expectations and removes the scheduler-dependent CI flake.

masih added 2 commits April 28, 2026 18:59
Several consensus tests enqueue round-N proposals before the state machine
has observed the transition into round N. Under -race, those queued
messages can be handled while the state is still in the previous round, so
SetProposal drops the proposal and the test later times out waiting for the
CompleteProposal event.

Synchronizing on the NewRound event before calling SetProposalAndBlock
makes the test order match the state machine's expectations and removes the
scheduler-dependent CI flake.
@masih masih marked this pull request as ready for review April 28, 2026 18:01
@masih masih requested a review from pompon0 April 28, 2026 18:01
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 28, 2026, 6:03 PM

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.17%. Comparing base (72dee5d) to head (33cddac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
- Coverage   59.17%   59.17%   -0.01%     
==========================================
  Files        2097     2097              
  Lines      172485   172483       -2     
==========================================
- Hits       102067   102063       -4     
- Misses      61563    61566       +3     
+ Partials     8855     8854       -1     
Flag Coverage Δ
sei-chain-pr 68.81% <ø> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit 2118601 Apr 28, 2026
40 of 41 checks passed
@masih masih deleted the masih/tm-deflake-wait-for-rounds branch April 28, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants