Wait for new-round events before injecting test proposals#3330
Merged
Conversation
Several consensus tests enqueue round-N proposals before the state machine has observed the transition into round N. Under -race, those queued messages can be handled while the state is still in the previous round, so SetProposal drops the proposal and the test later times out waiting for the CompleteProposal event. Synchronizing on the NewRound event before calling SetProposalAndBlock makes the test order match the state machine's expectations and removes the scheduler-dependent CI flake.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3330 +/- ##
==========================================
- Coverage 59.17% 59.17% -0.01%
==========================================
Files 2097 2097
Lines 172485 172483 -2
==========================================
- Hits 102067 102063 -4
- Misses 61563 61566 +3
+ Partials 8855 8854 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
arajasek
approved these changes
Apr 28, 2026
pompon0
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several consensus tests enqueue round-N proposals before the state machine has observed the transition into round N. Under -race, those queued messages can be handled while the state is still in the previous round, so SetProposal drops the proposal and the test later times out waiting for the CompleteProposal event.
Synchronizing on the NewRound event before calling SetProposalAndBlock makes the test order match the state machine's expectations and removes the scheduler-dependent CI flake.