Cjl/expanded route api#3335
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
- Coverage 59.18% 59.14% -0.04%
==========================================
Files 2097 2097
Lines 172489 172353 -136
==========================================
- Hits 102092 101944 -148
- Misses 61542 61550 +8
- Partials 8855 8859 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kbhat1
reviewed
Apr 29, 2026
|
|
||
| // An object capable of routing/splitting reads and writes between databases. | ||
| type Router interface { | ||
|
|
Contributor
There was a problem hiding this comment.
nit: remove extra line here
Kbhat1
reviewed
Apr 29, 2026
|
|
||
| // Get a proof of the value for a key in a store. Some stores may not support proofs, | ||
| // and this method will return an error in that case. | ||
| GetProof(store string, key []byte) (*ics23.CommitmentProof, error) |
Contributor
There was a problem hiding this comment.
Maybe reserved for another PR but do we need a Has() method?
Contributor
Author
There was a problem hiding this comment.
Discussed in slack thread, this will be handled by a higher layer.
Kbhat1
approved these changes
Apr 29, 2026
blindchaser
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Adds methods to the
Routerinterface that allows a router to handle requests to iterate and requests for membership proofs.Testing performed to validate your change
unit tests