Skip to content

CheckTx cleanup#3347

Merged
pompon0 merged 3 commits into
mainfrom
gprusak-rpc-sharding3
Apr 30, 2026
Merged

CheckTx cleanup#3347
pompon0 merged 3 commits into
mainfrom
gprusak-rpc-sharding3

Conversation

@pompon0

@pompon0 pompon0 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor
  • removed sender field from ResponseCheckTx - it is never set, never used and ResponseCheckTx is never persisted.
  • removed unused results of runTx and grouped the remaining ones into a struct.

@pompon0 pompon0 requested review from sei-will and wen-coding April 30, 2026 11:23
@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 30, 2026, 11:25 AM

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.21%. Comparing base (08689b2) to head (0f5af37).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
- Coverage   59.21%   59.21%   -0.01%     
==========================================
  Files        2097     2097              
  Lines      172509   172489      -20     
==========================================
- Hits       102152   102133      -19     
+ Misses      61501    61500       -1     
  Partials     8856     8856              
Flag Coverage Δ
sei-chain-pr 67.07% <100.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-cosmos/baseapp/abci.go 61.92% <100.00%> (+0.13%) ⬆️
sei-cosmos/baseapp/baseapp.go 76.42% <100.00%> (-0.10%) ⬇️
sei-cosmos/baseapp/test_helpers.go 66.66% <100.00%> (ø)
sei-tendermint/internal/mempool/mempool.go 72.23% <ø> (-0.55%) ⬇️
sei-tendermint/internal/mempool/tx.go 76.28% <ø> (-0.56%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit b8eebf2 Apr 30, 2026
39 of 40 checks passed
@pompon0 pompon0 deleted the gprusak-rpc-sharding3 branch April 30, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants