Backport release/v6.5: fix(evmrpc): return null for out-of-range index in eth_getTransactionByBlock*AndIndex#3367
Merged
masih merged 1 commit intorelease/v6.5from May 1, 2026
Conversation
…ByBlock*AndIndex (#3320) ## Summary - `eth_getTransactionByBlockNumberAndIndex` and `eth_getTransactionByBlockHashAndIndex` were returning a JSON-RPC error when the requested transaction index exceeded the number of transactions in the block. - Per the [Ethereum JSON-RPC spec](https://ethereum.github.io/execution-apis/api/methods/eth_getTransactionByBlockNumberAndIndex), these methods must return `null` (not an error) when no transaction exists at the given index. - Changed `getTransactionWithBlock` to return `(nil, nil)` instead of `(nil, error)` on out-of-range index, and updated the corresponding test. (cherry picked from commit d67dd88)
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v6.5 #3367 +/- ##
=============================================
Coverage 58.31% 58.32%
=============================================
Files 2093 2093
Lines 173242 173229 -13
=============================================
- Hits 101029 101028 -1
+ Misses 63152 63142 -10
+ Partials 9061 9059 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
masih
approved these changes
May 1, 2026
arajasek
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3320 to
release/v6.5.