Fix lint issues and clean up simulation gas accounting#3455
Conversation
Align simulation ante wiring with upstream and add a dedicated simulation VM Pass wasmkeeper.DefaultGasMeterSetter() to NewLimitSimulationGasDecorator in app/ante.go to match the reference wiring at sei-wasmd/app/ante.go. Add a dedicated simulationWasmVM on Keeper alongside the existing rpcWasmVM, plus an IsSimulation flag on sdk.Context that BaseApp.runTx sets for runTxModeSimulate. Keeper.getWasmer returns the dedicated VM for simulate-mode contexts, mirroring the existing tracing wiring. Adds unit tests for the ante wiring, the context flag, and the engine selection.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
PR SummaryMedium Risk Overview Introduces an Includes a small lint/security-scan suppression for safe Reviewed by Cursor Bugbot for commit a88e401. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
=======================================
Coverage 59.29% 59.30%
=======================================
Files 2126 2126
Lines 175702 175714 +12
=======================================
+ Hits 104183 104200 +17
+ Misses 62448 62440 -8
- Partials 9071 9074 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Align simulation ante wiring with upstream and add a dedicated simulation VM Pass wasmkeeper.DefaultGasMeterSetter() to NewLimitSimulationGasDecorator in app/ante.go to match the reference wiring at sei-wasmd/app/ante.go.
Add a dedicated simulationWasmVM on Keeper alongside the existing rpcWasmVM, plus an IsSimulation flag on sdk.Context that BaseApp.runTx sets for runTxModeSimulate. Keeper.getWasmer returns the dedicated VM for simulate-mode contexts, mirroring the existing tracing wiring.
Adds unit tests for the ante wiring, the context flag, and the engine selection.