Fix pre-v6.5 debug trace tx decoding#3470
Conversation
PR SummaryMedium Risk Overview Adds support utilities to detect upgrade activation ( Reviewed by Cursor Bugbot for commit 34bfeaa. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3470 +/- ##
=======================================
Coverage 59.07% 59.07%
=======================================
Files 2186 2187 +1
Lines 182269 182299 +30
=======================================
+ Hits 107671 107702 +31
Misses 64947 64947
+ Partials 9651 9650 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9fe8237. Configure here.
…ical-decode-main # Conflicts: # evmrpc/simulate.go # evmrpc/simulate_test.go
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-3470-to-release/v6.5
git worktree add --checkout .worktree/backport-3470-to-release/v6.5 backport-3470-to-release/v6.5
cd .worktree/backport-3470-to-release/v6.5
git reset --hard HEAD^
git cherry-pick -x 5098e5b0e902f51d8966003f33aaa440fde9b0d5
git push --force-with-lease |
- Add a trace-only pre-v6.5 tx decoder that skips the new TxBody bloat check - Use it when replaying historical debug_trace* blocks so old Cosmos tx bytes don’t break tracing - Add a regression test for an old tx with explicit memo=""; pre-v6.5 trace works, v6.5+ stays strict - Unit tests - Verifying on node (cherry picked from commit 5098e5b)
Backport of #3470 to `release/v6.5`. Co-authored-by: Kartik Bhat <kartikbhatri@gmail.com>

Describe your changes and provide context
Testing performed to validate your change