add new storage test panel#3487
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
PR SummaryLow Risk Overview The existing The new Reviewed by Cursor Bugbot for commit a27f493. Bugbot is set up for automated code reviews on this repo. Configure here. |
masih
left a comment
There was a problem hiding this comment.
I understand this the pre-step in more tests to come since today it won't make the slowest mandatory CI job any faster. Which means total wait time is unchanged.
No blockers regardless and glad to see experimentation here 🙌
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 2187 2187
Lines 181425 181425
=======================================
Hits 107102 107102
Misses 64701 64701
Partials 9622 9622
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,194 @@ | |||
| name: DB | |||
There was a problem hiding this comment.
how about name it State DB Tests
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a27f493. Configure here.
| # Upload under a separate flag to avoid apples-to-oranges project comparisons. | ||
| name: ${{ github.event_name == 'pull_request' && 'sei-db-state-db-pr-coverage' || 'sei-db-state-db-coverage' }} | ||
| files: ./coverage.out | ||
| flags: ${{ github.event_name == 'pull_request' && 'sei-db-state-db-pr' || 'sei-db-state-db' }} |
There was a problem hiding this comment.
New Codecov flags missing from codecov.yml configuration
Low Severity
The new workflow uploads coverage to Codecov using flags sei-db-state-db and sei-db-state-db-pr, but codecov.yml doesn't define these flags. Without a carryforward: true entry for sei-db-state-db, if the workflow run fails or is cancelled for a commit, Codecov won't carry forward prior data — the merged project coverage may appear to drop, potentially triggering a confusing regression on the default project status check.
Reviewed by Cursor Bugbot for commit a27f493. Configure here.


Describe your changes and provide context
In order to speed up test runtime, split storage unit tests into a stand alone panel.
I downloaded the logs from the new panels and from the old panels, and used an LLM to verify that the expected tests are running in each panel.