Remove crisis module wiring and code by codchen · Pull Request #3510 · sei-protocol/sei-chain

codchen · 2026-05-27T03:15:38Z

Summary

remove x/crisis from the Sei app wiring and delete the sei-cosmos/x/crisis module plus its crisis protobuf definitions
remove stale crisis wiring from wasmd/simapp test harnesses, local genesis setup, state-dump tooling, and module lists
confirmed crisis does not have a dedicated rootmulti KVStore: its former state was params-subspace data under the params store, so this PR does not add a StoreUpgrades deletion for crisis
skip stale/unknown module entries during streaming genesis import and validation, matching the non-streaming behavior for existing genesis files that still include crisis app_state

Test Plan

go test ./sei-cosmos/types/module
go test ./sei-cosmos/x/genutil/client/cli
go test ./app
go test ./app ./app/legacyabci ./cmd/seid/cmd ./sei-wasmd/app ./sei-wasmd/x/wasm/keeper ./sei-ibc-go/testing/simapp/... ./sei-db/tools/cmd/seidb/operations
4-node Docker upgrade test: started the pre-removal parent binary 5ac709d, let the chain run, passed the software upgrade at height 306, restarted all validators on the crisis-deletion binary, and verified all nodes reached height 366 with catching_up=false and matching app hash 60C93CD1D72AD425D3FD862D115D722B098FEC48A28FD795C466807403F4648A

cursor · 2026-05-27T03:16:22Z

PR Summary

Medium Risk
Removes periodic invariant checks and crisis halt behavior from the node, but verify-invariant was already disabled; streaming genesis skip is needed for compatibility with existing genesis that still lists crisis.

Overview
Removes the Cosmos x/crisis module from Sei: the module package, protos, invariant end-blocker, CLI (invariant-broken), and all app wiring (keeper, invCheckPeriod, genesis order, RegisterInvariants, export-time AssertInvariants).

The same cleanup is applied to wasmd, IBC simapp, and wasm test harnesses; local genesis and state-dump tooling no longer reference crisis.

Streaming genesis now ignores unknown module names (e.g. legacy crisis in chain genesis JSON) during validation and InitGenesis, with tests covering that path—so existing genesis files that still include crisis app_state keep working without a store upgrade (crisis state lived under params subspace, not a dedicated KV store).

^{Reviewed by Cursor Bugbot for commit ea7e4f3. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-05-27T03:17:16Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Jun 10, 2026, 9:55 AM

codecov · 2026-05-27T03:19:13Z

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.33%. Comparing base (ba465c7) to head (ea7e4f3).

Files with missing lines	Patch %	Lines
sei-cosmos/types/module/module.go	78.57%	2 Missing and 1 partial ⚠️
cmd/seid/cmd/root.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   59.16%   58.33%   -0.84%     
==========================================
  Files        2226     2152      -74     
  Lines      183561   174986    -8575     
==========================================
- Hits       108613   102073    -6540     
+ Misses      65167    63831    -1336     
+ Partials     9781     9082     -699

Flag	Coverage Δ
sei-chain-pr	`54.26% <76.47%> (?)`
sei-db	`70.41% <ø> (ø)`
sei-db-state-db	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app/app.go	`71.03% <ø> (-0.18%)`	⬇️
app/export.go	`0.00% <ø> (ø)`
app/legacyabci/end_block.go	`100.00% <ø> (ø)`
sei-ibc-go/testing/simapp/app.go	`76.64% <100.00%> (-0.75%)`	⬇️
sei-ibc-go/testing/simapp/export.go	`0.00% <ø> (ø)`
sei-ibc-go/testing/simapp/simd/cmd/root.go	`66.87% <100.00%> (-0.21%)`	⬇️
sei-wasmd/app/app.go	`84.07% <ø> (-0.51%)`	⬇️
sei-wasmd/app/export.go	`12.24% <ø> (+0.12%)`	⬆️
cmd/seid/cmd/root.go	`25.09% <0.00%> (+0.09%)`	⬆️
sei-cosmos/types/module/module.go	`68.27% <78.57%> (+7.93%)`	⬆️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

masih · 2026-05-28T11:03:45Z

@@ -170,8 +169,7 @@ func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig) {
 	rootCmd.AddCommand(server.RosettaCommand(encodingConfig.InterfaceRegistry, encodingConfig.Marshaler))
 }

-func addModuleInitFlags(startCmd *cobra.Command) {
-	crisis.AddModuleInitFlags(startCmd)


This would break the startup for anyone setting the flag.

Perhaps a more graceful approach is to print a WARNING saying this is noop, and flag will be removed in the next release.

Alternatively a more meaningful fatal error to point them to some TBD comms (e.g. release notes) that would explain the module removal).

This simapp is only used in unit tests so I think it should be okay, and once ibc is removed we will remove this simapp altogether too

masih · 2026-05-28T11:10:23Z

 		app.SetStoreLoader(upgradetypes.UpgradeStoreLoader(upgradeInfo.Height, &storeUpgrades))
 	}
+
+	if (upgradeInfo.Name == "v6.6.0") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) {


Going forward since v6.5, upgrade names will follow v<major>.<minor> format. No more repetitive .0 suffix.

Suggested change

if (upgradeInfo.Name == "v6.6.0") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) {

if (upgradeInfo.Name == "v6.6") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) {

masih · 2026-05-28T14:05:02Z

+
+	if (upgradeInfo.Name == "v6.6.0") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) {
+		storeUpgrades := storetypes.StoreUpgrades{
+			Deleted: []string{crisisStoreKeyName},


But there is no such key name and this would result in an error i believe.

philipsu522

In the past, when updating some fields for modules I believe we saw some incompatibilities. For this particular PR, in the genesis file we see:
https://github.com/sei-protocol/chain-configs/blob/main/pacific-1/genesis.json#L715

We should probably test workflows like state sync'ing with the new binary and the genesis file

codchen · 2026-06-01T04:10:28Z

Checked the genesis/state-sync concern.

The concern is valid for paths that stream or validate app_state from existing genesis files, because pacific-1/arctic-1/atlantic-2 genesis still include a crisis entry. Normal JSON genesis import already iterates registered modules and skips unknown module keys, so the removed crisis app_state is not used there. Standard state sync should rely on the genesis doc plus snapshots rather than running removed module InitGenesis from app_state, so I do not see a separate failure in that path from the crisis entry itself.

I did find and fix the risky streaming paths in 667afb9:

streaming InitGenesis skips unknown modules before calling InitGenesis
streaming ValidateGenesis drains/skips unknown module chunks instead of indexing a missing module
added regression coverage using a streamed crisis genesis payload

Validated with:

go test ./sei-cosmos/types/module
go test ./sei-cosmos/x/genutil/client/cli
go test ./app

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 667afb9. Configure here.}

cursor · 2026-06-01T04:13:06Z

-func addModuleInitFlags(startCmd *cobra.Command) {
-	crisis.AddModuleInitFlags(startCmd)
-}
+func addModuleInitFlags(_ *cobra.Command) {}


Removed CLI flag breaks operators using it

Medium Severity

The --x-crisis-skip-assert-invariants flag is silently removed by making addModuleInitFlags a no-op. Any operator who has this flag in their seid start command (e.g. in a systemd unit file or launch script) will get an "unknown flag" error from cobra, preventing the node from starting after the upgrade. As the PR reviewer noted, a graceful deprecation (accepting the flag as a no-op with a warning) would avoid unexpected startup failures.

Additional Locations (1)

sei-ibc-go/testing/simapp/simd/cmd/root.go#L171-L173

^{Reviewed by Cursor Bugbot for commit 667afb9. Configure here.}

Drop x/crisis from the Sei app module manager, init-genesis order, end blocker, invariant registration, init flags, and app-owned keeper state. Crisis has no dedicated mounted KV store in app/app.go, so the rootmulti store key list is unchanged. Also decouple crisis package tests from the full app now that App no longer exposes CrisisKeeper. Tested with: go test ./app ./app/legacyabci ./cmd/seid/cmd ./sei-cosmos/x/crisis/... Upgrade tested with a 4-node Docker cluster: started from the pre-removal binary, passed software upgrade v99.0.1-crisis-removal at height 342, restarted all validators on the removal binary, and verified all nodes reached height 514 with catching_up=false and matching app hash A53F9F78B05C8F6C07247186EF5BFB89D5BCFE7535AE52E54895B57E1844485E.

codchen added the app-hash-breaking label May 27, 2026

codchen changed the title ~~Remove crisis module from app wiring~~ Remove crisis module code and store May 28, 2026

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread app/app.go Outdated

masih reviewed May 28, 2026

View reviewed changes

cursor Bot reviewed May 29, 2026

View reviewed changes

Comment thread app/app.go

philipsu522 approved these changes May 29, 2026

View reviewed changes

philipsu522 reviewed May 29, 2026

View reviewed changes

codchen changed the title ~~Remove crisis module code and store~~ Remove crisis module wiring and code Jun 1, 2026

cursor Bot reviewed Jun 1, 2026

View reviewed changes

codchen added 5 commits June 10, 2026 17:51

Remove crisis module code and store

09b5004

Set crisis removal upgrade to v6.6.0

9656f4d

Remove crisis store deletion hook

7b638f1

Skip unknown modules in streaming genesis

ea7e4f3

codchen force-pushed the codex/remove-crisis-app-module branch from 667afb9 to ea7e4f3 Compare June 10, 2026 09:53

codchen added this pull request to the merge queue Jun 10, 2026

Merged via the queue into main with commit 3c0c729 Jun 10, 2026
55 checks passed

codchen deleted the codex/remove-crisis-app-module branch June 10, 2026 13:21

	if (upgradeInfo.Name == "v6.6.0") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) {
	if (upgradeInfo.Name == "v6.6") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) {

Uh oh!

Conversation

codchen commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

cursor Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

github-actions Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

masih May 28, 2026

Choose a reason for hiding this comment

Uh oh!

codchen Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

masih May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

masih May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

philipsu522 left a comment

Choose a reason for hiding this comment

Uh oh!

codchen commented Jun 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jun 1, 2026

Choose a reason for hiding this comment

Removed CLI flag breaks operators using it

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codchen commented May 27, 2026 •

edited

Loading

cursor Bot commented May 27, 2026 •

edited

Loading

github-actions Bot commented May 27, 2026 •

edited

Loading

codecov Bot commented May 27, 2026 •

edited

Loading